[SPARK-32469][SQL] ApplyColumnarRulesAndInsertTransitions should be idempotent #29273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
reviewed
Jul 28, 2020
| @@ -490,8 +490,10 @@ case class ApplyColumnarRulesAndInsertTransitions(conf: SQLConf, columnarRules: | |||
| // The tree feels kind of backwards | |||
| // Columnar Processing will start here, so transition from row to columnar | |||
| RowToColumnarExec(insertTransitions(plan)) | |||
| } else { | |||
| } else if (!plan.isInstanceOf[RowToColumnarExec]) { | |||
There was a problem hiding this comment.
I had gone down the same path at one point with similar changes, but then had to introduce a new RowToColumnarExecLike trait so that it would also work with the GpuRowToColumnarExec implementation that we have in our plugin.
There was a problem hiding this comment.
do you mean https://github.com/apache/spark/pull/29067/files#diff-3a92abd70b28650055b16d8a101a95c3R55 ?
I can wait for it to be merged, and add something similar for RowToColumnarExec.
|
Test build #126727 has finished for PR 29273 at commit
|
|
Test build #126982 has finished for PR 29273 at commit
|
|
thanks for review, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR makes
ApplyColumnarRulesAndInsertTransitionsidempotent (assuming the custom columnar rules are also idempotent).Why are the changes needed?
It's good hygiene to keep rules idempotent
Does this PR introduce any user-facing change?
No
How was this patch tested?
new suite