Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-32688][SQL][TEST] Add special values to LiteralGenerator for float and double #29515

Closed
wants to merge 8 commits into from
Closed

[SPARK-32688][SQL][TEST] Add special values to LiteralGenerator for float and double #29515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8c8313c
Add special values to LiteralGenerator for float and double
tanelk Aug 22, 2020
77d63ac
Add 'MaxValue' to LiteralGenerator for float and double
tanelk Aug 23, 2020
818abe2
Ensure -0.0 and 0.0 comparison consistency
tanelk Aug 23, 2020
1116d3d
Revert equality check
tanelk Aug 23, 2020
2dce36e
test -0.0 equality for complex types
tanelk Aug 23, 2020
9a3b983
Add -0.0 as special value to RandomDataGenerator
tanelk Aug 24, 2020
d20a2ed
revert test -0.0 equality for complex types
tanelk Sep 4, 2020
529aba8
revert test -0.0 equality for complex types
tanelk Sep 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/RandomDataGenerator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,10 +260,10 @@ object RandomDataGenerator {
new MathContext(precision)).bigDecimal)
case DoubleType => randomNumeric[Double](
rand, r => longBitsToDouble(r.nextLong()), Seq(Double.MinValue, Double.MinPositiveValue,
Double.MaxValue, Double.PositiveInfinity, Double.NegativeInfinity, Double.NaN, 0.0))
Double.MaxValue, Double.PositiveInfinity, Double.NegativeInfinity, Double.NaN, 0.0, -0.0))
case FloatType => randomNumeric[Float](
rand, r => intBitsToFloat(r.nextInt()), Seq(Float.MinValue, Float.MinPositiveValue,
Float.MaxValue, Float.PositiveInfinity, Float.NegativeInfinity, Float.NaN, 0.0f))
Float.MaxValue, Float.PositiveInfinity, Float.NegativeInfinity, Float.NaN, 0.0f, -0.0f))
case ByteType => randomNumeric[Byte](
rand, _.nextInt().toByte, Seq(Byte.MinValue, Byte.MaxValue, 0.toByte))
case IntegerType => randomNumeric[Int](
Expand Down
19 changes: 15 additions & 4 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/LiteralGenerator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,16 +68,27 @@ object LiteralGenerator {
lazy val longLiteralGen: Gen[Literal] =
for { l <- Arbitrary.arbLong.arbitrary } yield Literal.create(l, LongType)

// The floatLiteralGen and doubleLiteralGen will 50% of the time yield arbitrary values
// and 50% of the time will yield some special values that are more likely to reveal
// corner cases. This behavior is similar to the integral value generators.
lazy val floatLiteralGen: Gen[Literal] =
for {
f <- Gen.chooseNum(Float.MinValue / 2, Float.MaxValue / 2,
Float.NaN, Float.PositiveInfinity, Float.NegativeInfinity)
tanelk marked this conversation as resolved.
Show resolved Hide resolved
f <- Gen.oneOf(
Gen.oneOf(
Float.NaN, Float.PositiveInfinity, Float.NegativeInfinity, Float.MinPositiveValue,
tanelk marked this conversation as resolved.
Show resolved Hide resolved
Float.MaxValue, -Float.MaxValue, 0.0f, -0.0f, 1.0f, -1.0f),
Arbitrary.arbFloat.arbitrary
tanelk marked this conversation as resolved.
Show resolved Hide resolved
)
} yield Literal.create(f, FloatType)

lazy val doubleLiteralGen: Gen[Literal] =
for {
f <- Gen.chooseNum(Double.MinValue / 2, Double.MaxValue / 2,
Double.NaN, Double.PositiveInfinity, Double.NegativeInfinity)
f <- Gen.oneOf(
Gen.oneOf(
Double.NaN, Double.PositiveInfinity, Double.NegativeInfinity, Double.MinPositiveValue,
Double.MaxValue, -Double.MaxValue, 0.0, -0.0, 1.0, -1.0),
Arbitrary.arbDouble.arbitrary
)
} yield Literal.create(f, DoubleType)

// TODO cache the generated data
Expand Down