[SPARK-32813][SQL] Get default config of ParquetSource vectorized reader if no active SparkSession #29667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Sep 8, 2020
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Sep 8, 2020
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLExecutionSuite.scala
Outdated
Show resolved
Hide resolved
HyukjinKwon
reviewed
Sep 8, 2020
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLExecutionSuite.scala
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLExecutionSuite.scala
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLExecutionSuite.scala
Show resolved
Hide resolved
|
The change itself looks good. |
cloud-fan
approved these changes
Sep 8, 2020
HyukjinKwon
approved these changes
Sep 8, 2020
cloud-fan
reviewed
Sep 8, 2020
|
|
||
| withTempDir { tempDir => | ||
| try { | ||
| val tablePath = tempDir.toString + "/table" |
There was a problem hiding this comment.
nit: why don't we use tempDir directly?
There was a problem hiding this comment.
will complain ... dir was already existing.
There was a problem hiding this comment.
oh, can we try withTempPath?
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLExecutionSuite.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Since this is ParquetSource-only bug and fix, could you narrow-down the PR title and description? Or, is this applicable for the other code path, @viirya ?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
retest this please |
|
Test build #128386 has finished for PR 29667 at commit
|
viirya
changed the title
|
@dongjoon-hyun I updated the PR title and description. Thank you. |
dongjoon-hyun
approved these changes
Sep 9, 2020
|
Test build #128426 has finished for PR 29667 at commit
|
HyukjinKwon
pushed a commit
that referenced
this pull request
Sep 9, 2020
…der if no active SparkSession ### What changes were proposed in this pull request? If no active SparkSession is available, let `FileSourceScanExec.needsUnsafeRowConversion` look at default SQL config of ParquetSource vectorized reader instead of failing the query execution. ### Why are the changes needed? Fix a bug that if no active SparkSession is available, file-based data source scan for Parquet Source will throw exception. ### Does this PR introduce _any_ user-facing change? Yes, this change fixes the bug. ### How was this patch tested? Unit test. Closes #29667 from viirya/SPARK-32813. Authored-by: Liang-Chi Hsieh <viirya@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit de0dc52) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
|
Merged to master and branch-3.0. |
|
Thanks all! |
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Oct 27, 2020
…der if no active SparkSession ### What changes were proposed in this pull request? If no active SparkSession is available, let `FileSourceScanExec.needsUnsafeRowConversion` look at default SQL config of ParquetSource vectorized reader instead of failing the query execution. ### Why are the changes needed? Fix a bug that if no active SparkSession is available, file-based data source scan for Parquet Source will throw exception. ### Does this PR introduce _any_ user-facing change? Yes, this change fixes the bug. ### How was this patch tested? Unit test. Closes apache#29667 from viirya/SPARK-32813. Authored-by: Liang-Chi Hsieh <viirya@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit de0dc52) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
asiunov
pushed a commit
to ascend-io/spark
that referenced
this pull request
May 26, 2021
…der if no active SparkSession ### What changes were proposed in this pull request? If no active SparkSession is available, let `FileSourceScanExec.needsUnsafeRowConversion` look at default SQL config of ParquetSource vectorized reader instead of failing the query execution. ### Why are the changes needed? Fix a bug that if no active SparkSession is available, file-based data source scan for Parquet Source will throw exception. ### Does this PR introduce _any_ user-facing change? Yes, this change fixes the bug. ### How was this patch tested? Unit test. Closes apache#29667 from viirya/SPARK-32813. Authored-by: Liang-Chi Hsieh <viirya@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If no active SparkSession is available, let
FileSourceScanExec.needsUnsafeRowConversionlook at default SQL config of ParquetSource vectorized reader instead of failing the query execution.Why are the changes needed?
Fix a bug that if no active SparkSession is available, file-based data source scan for Parquet Source will throw exception.
Does this PR introduce any user-facing change?
Yes, this change fixes the bug.
How was this patch tested?
Unit test.