[SPARK-32677][SQL][DOCS][MINOR] Improve code comment in CreateFunctionCommand #29713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
HyukjinKwon
approved these changes
Sep 10, 2020
maropu
approved these changes
Sep 10, 2020
|
Thanks to correct this, it's good to improve the comment! |
|
Test build #128516 has finished for PR 29713 at commit
|
maropu
changed the title
maropu
pushed a commit
that referenced
this pull request
Sep 11, 2020
…nCommand ### What changes were proposed in this pull request? We made a mistake in #29502, as there is no code comment to explain why we can't load the UDF class when creating functions. This PR improves the code comment. ### Why are the changes needed? To avoid making the same mistake. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? N/A Closes #29713 from cloud-fan/comment. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org> (cherry picked from commit 328d81a) Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
|
Thanks! Merged to master/3.0. |
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Oct 27, 2020
…nCommand ### What changes were proposed in this pull request? We made a mistake in apache#29502, as there is no code comment to explain why we can't load the UDF class when creating functions. This PR improves the code comment. ### Why are the changes needed? To avoid making the same mistake. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? N/A Closes apache#29713 from cloud-fan/comment. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org> (cherry picked from commit 328d81a) Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We made a mistake in #29502, as there is no code comment to explain why we can't load the UDF class when creating functions. This PR improves the code comment.
Why are the changes needed?
To avoid making the same mistake.
Does this PR introduce any user-facing change?
No
How was this patch tested?
N/A