[SPARK-33015][SQL][FOLLOWUP][3.0] Use millisToDays() in the ComputeCurrentTime rule #29901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Sep 29, 2020
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #129222 has finished for PR 29901 at commit
|
|
Merged to branch-3.0. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Sep 29, 2020
…rrentTime rule ### What changes were proposed in this pull request? Use `millisToDays()` instead of `microsToDays()` because the former one is not available in `branch-3.0`. ### Why are the changes needed? To fix the build failure: ``` [ERROR] [Error] /home/jenkins/workspace/spark-branch-3.0-maven-snapshots/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala:85: value microsToDays is not a member of object org.apache.spark.sql.catalyst.util.DateTimeUtils ``` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? By running `./build/sbt clean package` and `ComputeCurrentTimeSuite`. Closes #29901 from MaxGekk/fix-current_date-3.0. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Oct 27, 2020
…rrentTime rule ### What changes were proposed in this pull request? Use `millisToDays()` instead of `microsToDays()` because the former one is not available in `branch-3.0`. ### Why are the changes needed? To fix the build failure: ``` [ERROR] [Error] /home/jenkins/workspace/spark-branch-3.0-maven-snapshots/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala:85: value microsToDays is not a member of object org.apache.spark.sql.catalyst.util.DateTimeUtils ``` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? By running `./build/sbt clean package` and `ComputeCurrentTimeSuite`. Closes apache#29901 from MaxGekk/fix-current_date-3.0. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use
millisToDays()instead ofmicrosToDays()because the former one is not available inbranch-3.0.Why are the changes needed?
To fix the build failure:
Does this PR introduce any user-facing change?
No
How was this patch tested?
By running
./build/sbt clean packageandComputeCurrentTimeSuite.