Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-26218][SQL][FOLLOW UP] Fix the corner case of codegen when casting float to Integer #30585

Closed
wants to merge 1 commit into from

Conversation

luluorta
Copy link
Contributor

@luluorta luluorta commented Dec 3, 2020

What changes were proposed in this pull request?

This is a followup of #27151. It fixes the same issue for the codegen path.

Why are the changes needed?

Result corrupt.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Added Unit test.

@luluorta
Copy link
Contributor Author

luluorta commented Dec 3, 2020

cc @turboFei @cloud-fan

@github-actions github-actions bot added the SQL label Dec 3, 2020
@cloud-fan
Copy link
Contributor

ok to test

@cloud-fan
Copy link
Contributor

add to whitelist

@SparkQA
Copy link

SparkQA commented Dec 3, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36701/

@SparkQA
Copy link

SparkQA commented Dec 3, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36701/

@SparkQA
Copy link

SparkQA commented Dec 3, 2020

Test build #132101 has finished for PR 30585 at commit 5697260.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

retest this please

@SparkQA
Copy link

SparkQA commented Dec 3, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36719/

@SparkQA
Copy link

SparkQA commented Dec 3, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36720/

@SparkQA
Copy link

SparkQA commented Dec 3, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36720/

@SparkQA
Copy link

SparkQA commented Dec 3, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36719/

@SparkQA
Copy link

SparkQA commented Dec 3, 2020

Test build #132119 has finished for PR 30585 at commit b07a9c7.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

GA passed, merging to master, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants