Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-33652][SQL] DSv2: DeleteFrom should refresh cache #30597

Closed
wants to merge 2 commits into from
Closed

[SPARK-33652][SQL] DSv2: DeleteFrom should refresh cache #30597

wants to merge 2 commits into from

Conversation

sunchao
Copy link
Member

@sunchao sunchao commented Dec 4, 2020

What changes were proposed in this pull request?

This changes DeleteFromTableExec to also refresh caches referencing the original table, by passing the refreshCache callback to the class. Note that in order to construct the callback, I have to change DataSourceV2ScanRelation to contain a DataSourceV2Relation instead of a Table.

Why are the changes needed?

Currently DSv2 delete from table doesn't refresh caches. This could lead to correctness issue if the staled cache is queried later.

Does this PR introduce any user-facing change?

Yes. Now delete from table in v2 also refreshes cache.

How was this patch tested?

Added a test case.

@github-actions github-actions bot added the SQL label Dec 4, 2020
@SparkQA
Copy link

SparkQA commented Dec 4, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36767/

@SparkQA
Copy link

SparkQA commented Dec 4, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36767/

@SparkQA
Copy link

SparkQA commented Dec 4, 2020

Test build #132166 has finished for PR 30597 at commit 66c968c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Retest this please.

@SparkQA
Copy link

SparkQA commented Dec 4, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36809/

@SparkQA
Copy link

SparkQA commented Dec 4, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36809/

@SparkQA
Copy link

SparkQA commented Dec 4, 2020

Test build #132209 has finished for PR 30597 at commit 66c968c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member

viirya commented Dec 4, 2020

retest this please

@SparkQA
Copy link

SparkQA commented Dec 4, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36849/

@SparkQA
Copy link

SparkQA commented Dec 4, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36849/

@SparkQA
Copy link

SparkQA commented Dec 5, 2020

Test build #132248 has finished for PR 30597 at commit 66c968c.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 5, 2020

Test build #132257 has finished for PR 30597 at commit eb5646f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

dongjoon-hyun
dongjoon-hyun approved these changes Dec 6, 2020
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @sunchao , @HyukjinKwon , and @viirya .
Merged to master/3.1.

dongjoon-hyun pushed a commit that referenced this pull request Dec 6, 2020
@sunchao @dongjoon-hyun
[SPARK-33652][SQL] DSv2: DeleteFrom should refresh cache
97e65b9 
### What changes were proposed in this pull request?

This changes `DeleteFromTableExec` to also refresh caches referencing the original table, by passing the `refreshCache` callback to the class. Note that in order to construct the callback, I have to change `DataSourceV2ScanRelation` to contain a `DataSourceV2Relation` instead of a `Table`.

### Why are the changes needed?

Currently DSv2 delete from table doesn't refresh caches. This could lead to correctness issue if the staled cache is queried later.

### Does this PR introduce _any_ user-facing change?

Yes. Now delete from table in v2 also refreshes cache.

### How was this patch tested?

Added a test case.

Closes #30597 from sunchao/SPARK-33652.

Authored-by: Chao Sun <sunchao@apple.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit e857e06)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@sunchao
Copy link
Member Author

sunchao commented Dec 7, 2020

Thanks for merging @dongjoon-hyun !

@sunchao sunchao deleted the SPARK-33652 branch December 7, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viirya viirya viirya left review comments

@HyukjinKwon HyukjinKwon HyukjinKwon left review comments

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees
No one assigned
Labels
SQL
Projects
None yet
Milestone
No milestone
5 participants
@sunchao @SparkQA @dongjoon-hyun @viirya @HyukjinKwon