[SPARK-28863][SQL][FOLLOWUP][3.0] Make sure optimized plan will not be re-analyzed #30872
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #30777 to 3.0
What changes were proposed in this pull request?
It's a known issue that re-analyzing an optimized plan can lead to various issues. We made several attempts to avoid it from happening, but the current solution
AlreadyOptimized
is still not 100% safe, as people can inject catalyst rules to call analyzer directly.This PR proposes a simpler and safer idea: we set the
analyzed
flag to true after optimization, and analyzer will skip processing plans whoseanalyzed
flag is true.Why are the changes needed?
make the code simpler and safer
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests.