[SPARK-34504][SQL] Avoid unnecessary resolving of SQL temp views for DDL commands #31853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
commented
Mar 16, 2021
| @@ -1147,16 +1152,10 @@ class Analyzer(override val catalogManager: CatalogManager) | |||
| } | |||
| // Fail the analysis eagerly because outside AnalysisContext, the unresolved operators | |||
| // inside a view maybe resolved incorrectly. | |||
| // But for commands like `DropViewCommand`, resolving view is unnecessary even though | |||
| // there is unresolved node. So use the `performCheck` flag to skip the analysis check | |||
| // for these commands. | |||
There was a problem hiding this comment.
This trick doesn't always work. Sometimes the analyzer may fail eagerly instead of waiting for checkAnalysis.
maropu
reviewed
Mar 16, 2021
| @@ -950,8 +950,7 @@ class Analyzer(override val catalogManager: CatalogManager) | |||
|
|
|||
| def lookupTempView( | |||
maropu
reviewed
Mar 16, 2021
| tmpView | ||
| } | ||
|
|
||
| def lookupAndResolveTempView( |
yaooqinn
approved these changes
Mar 16, 2021
yaooqinn
approved these changes
Mar 16, 2021
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
viirya
approved these changes
Mar 16, 2021
dongjoon-hyun
approved these changes
Mar 16, 2021
|
Test build #136119 has finished for PR 31853 at commit
|
|
Hm, the scala-2.13 build failure seems to be not related to this PR and it is reported in https://issues.apache.org/jira/browse/SPARK-34762. |
|
yea the scala 2.13 issue is not related, I'm merging it to master/3.1, thanks for the review! |
cloud-fan
added a commit
that referenced
this pull request
Mar 17, 2021
…DDL commands For DDL commands like DROP VIEW, they don't really need to resolve the view (parse and analyze the view SQL text), they just need to get the view metadata. This PR fixes the rule `ResolveTempViews` to only resolve the temp view for `UnresolvedRelation`. This also fixes a bug for DROP VIEW, as previously it tried to resolve the view and failed to drop invalid views. bug fix no new test Closes #31853 from cloud-fan/view-resolve. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit af55373) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
|
late LGTM |
flyrain
pushed a commit
to flyrain/spark
that referenced
this pull request
Sep 21, 2021
…DDL commands For DDL commands like DROP VIEW, they don't really need to resolve the view (parse and analyze the view SQL text), they just need to get the view metadata. This PR fixes the rule `ResolveTempViews` to only resolve the temp view for `UnresolvedRelation`. This also fixes a bug for DROP VIEW, as previously it tried to resolve the view and failed to drop invalid views. bug fix no new test Closes apache#31853 from cloud-fan/view-resolve. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit af55373) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
fishcus
pushed a commit
to fishcus/spark
that referenced
this pull request
Jan 12, 2022
…DDL commands For DDL commands like DROP VIEW, they don't really need to resolve the view (parse and analyze the view SQL text), they just need to get the view metadata. This PR fixes the rule `ResolveTempViews` to only resolve the temp view for `UnresolvedRelation`. This also fixes a bug for DROP VIEW, as previously it tried to resolve the view and failed to drop invalid views. bug fix no new test Closes apache#31853 from cloud-fan/view-resolve. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit af55373) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For DDL commands like DROP VIEW, they don't really need to resolve the view (parse and analyze the view SQL text), they just need to get the view metadata.
This PR fixes the rule
ResolveTempViewsto only resolve the temp view forUnresolvedRelation. This also fixes a bug for DROP VIEW, as previously it tried to resolve the view and failed to drop invalid views.Why are the changes needed?
bug fix
Does this PR introduce any user-facing change?
no
How was this patch tested?
new test