[SPARK-33482][SPARK-34756][SQL][3.0] Fix FileScan equality check #31952
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This bug was introduced by SPARK-30428 at Apache Spark 3.0.0.
This PR fixes
FileScan.equals()
.Why are the changes needed?
FileScan.equals
doesn't takefileIndex
andreadSchema
into account.FileScan
(in [SPARK-30428][SQL] File source V2: support partition pruning #27112 and [SPARK-30475][SQL] File source V2: Push data filters for file listing #27157) caused that canonicalized form of someBatchScanExec
nodes don't match and this prevents some reuse possibilities.Does this PR introduce any user-facing change?
Yes, before this fix incorrect reuse of
FileScan
and soBatchScanExec
could have happed causing correctness issues.How was this patch tested?
Added new UTs.