-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-35105][SQL] Support multiple paths for ADD FILE/JAR/ARCHIVE commands #32205
Conversation
Test build #755422826 for PR 32205 at commit |
Kubernetes integration test starting |
Kubernetes integration test status failure |
Test build #137486 has finished for PR 32205 at commit
|
@sarutak would you mind rebasing your branch against the latest master branch in Apache Spark? there have been a couple of CI updates so it has to be synced. |
@HyukjinKwon Thank you for letting me know. I'll update it. |
Kubernetes integration test starting |
Kubernetes integration test status failure |
Test build #137540 has finished for PR 32205 at commit
|
Test build #137572 has finished for PR 32205 at commit
|
Kubernetes integration test starting |
Kubernetes integration test status failure |
Test build #137596 has finished for PR 32205 at commit
|
@HyukjinKwon Do you have any comment on this change? |
Kubernetes integration test unable to build dist. exiting with code: 1 |
Test build #138009 has finished for PR 32205 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify, these are all supported in Hive too, right? If that's the case, I think the change is fine
Yes. It works in Hive as documented (https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Commands). |
Merged to |
…mmands ### What changes were proposed in this pull request? This PR extends `ADD FILE/JAR/ARCHIVE` commands to be able to take multiple path arguments like Hive. ### Why are the changes needed? To make those commands more useful. ### Does this PR introduce _any_ user-facing change? Yes. In the current implementation, those commands can take a path which contains whitespaces without enclose it by neither `'` nor `"` but after this change, users need to enclose such paths. I've note this incompatibility in the migration guide. ### How was this patch tested? New tests. Closes apache#32205 from sarutak/add-multiple-files. Authored-by: Kousuke Saruta <sarutak@oss.nttdata.com> Signed-off-by: Kousuke Saruta <sarutak@oss.nttdata.com>
What changes were proposed in this pull request?
This PR extends
ADD FILE/JAR/ARCHIVE
commands to be able to take multiple path arguments like Hive.Why are the changes needed?
To make those commands more useful.
Does this PR introduce any user-facing change?
Yes. In the current implementation, those commands can take a path which contains whitespaces without enclose it by neither
'
nor"
but after this change, users need to enclose such paths.I've note this incompatibility in the migration guide.
How was this patch tested?
New tests.