[SPARK-35235][SQL][TEST] Add row-based hash map into aggregate benchmark #32357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
@cloud-fan could you help take a look when you have time? Thanks. |
cloud-fan
reviewed
Apr 27, 2021
| codegen = F 10873 10998 176 7.7 129.6 1.0X | ||
| codegen = T, hashmap = F 5906 6005 95 14.2 70.4 1.8X | ||
| codegen = T, row-based hashmap = T 2325 2410 94 36.1 27.7 4.7X | ||
| codegen = T, vectorized hashmap = T 1185 1259 78 70.8 14.1 9.2X |
There was a problem hiding this comment.
interesting, we should probably pick vectorized hashmap under certain conditions.
There was a problem hiding this comment.
@cloud-fan - this sounds interesting to me. Created SPARK-35241 for followup, thanks.
cloud-fan
approved these changes
Apr 27, 2021
cloud-fan
changed the title
|
thanks, merging to master! |
|
Test build #137981 has finished for PR 32357 at commit
|
|
Thank you @cloud-fan for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
AggregateBenchmarkis only testing the performance for vectorized fast hash map, but not row-based hash map (which is used by default). We should add the row-based hash map into the benchmark.java 8 benchmark run - https://github.com/c21/spark/actions/runs/787731549
java 11 benchmark run - https://github.com/c21/spark/actions/runs/787742858
Why are the changes needed?
To have and track a basic sense of benchmarking different fast hash map used in hash aggregate.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing unit test, as this only touches benchmark code.