Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR][DOCS] Add required imports to CV, train validation split Pyspark ML examples #32554

Closed
wants to merge 3 commits into from

Conversation

srowen
Copy link
Member

@srowen srowen commented May 14, 2021

What changes were proposed in this pull request?

Add required imports to Pyspark ML examples in CrossValidator, TrainValidationSplit

Why are the changes needed?

The examples pass doctests because of previous imports, but as they appear in Pyspark documentation, are incomplete. The additional imports are required to make the example work.

Does this PR introduce any user-facing change?

No, docs only change.

How was this patch tested?

Existing tests.

@SparkQA
Copy link

SparkQA commented May 14, 2021

Test build #138567 has finished for PR 32554 at commit 62a333a.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 14, 2021

Test build #138568 has finished for PR 32554 at commit b002cea.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 14, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43088/

@SparkQA
Copy link

SparkQA commented May 14, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43088/

@SparkQA
Copy link

SparkQA commented May 14, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43089/

@SparkQA
Copy link

SparkQA commented May 14, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43089/

@SparkQA
Copy link

SparkQA commented May 14, 2021

Test build #138569 has finished for PR 32554 at commit eddb4b7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 15, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43090/

@huaxingao huaxingao changed the title [MINOR][DOCS} Add required imports to CV, train validation split Pyspark ML examples [MINOR][DOCS] Add required imports to CV, train validation split Pyspark ML examples May 15, 2021
@srowen
Copy link
Member Author

srowen commented May 15, 2021

Merged to master

@srowen srowen closed this in a37cce9 May 15, 2021
@srowen srowen deleted the TuningImports branch June 1, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants