Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-35457][BUILD] Bump ANTLR runtime version to 4.8 #32603

Closed
wants to merge 1 commit into from

Conversation

bozhang2820
Copy link
Contributor

What changes were proposed in this pull request?

This PR changes the antlr4-runtime version from 4.8-1 to 4.8.

Why are the changes needed?

Version 4.8 is the official release version, with a proper release note (see https://github.com/antlr/antlr4/releases) and artifiacts listed in https://www.antlr.org/download/index.html.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Will rely on tests in the PR.

@HyukjinKwon
Copy link
Member

cc @maropu and @dongjoon-hyun FYI

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, although 4.8-1 seems to be a weird version, this is not Bump. This PR looks like downgrading a version. Please revise the PR title if that is the case.

@dongjoon-hyun
Copy link
Member

Or, 4.8 is the successor of 4.8-1?

@bozhang2820
Copy link
Contributor Author

Or, 4.8 is the successor of 4.8-1?

Yes technically 4.8-1 is smaller than 4.8 (see https://semver.org/). Maybe we can change "Bump" to "Update" instead?

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented May 20, 2021

Oh, got it. Thank you for the explanation! In that case, it looks good to me. I was confused at that part.

@SparkQA
Copy link

SparkQA commented May 20, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43253/

@SparkQA
Copy link

SparkQA commented May 20, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43253/

@maropu maropu closed this in e170e63 May 20, 2021
@maropu
Copy link
Member

maropu commented May 20, 2021

Thanks! Merged to master.

@SparkQA
Copy link

SparkQA commented May 20, 2021

Test build #138731 has finished for PR 32603 at commit b8f20cc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants