-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-33475][BUILD] Bump ANTLR runtime version to 4.8-1 #30404
Conversation
cc @hvanhovell FYI |
Kubernetes integration test starting |
Kubernetes integration test status failure |
Test build #131248 has finished for PR 30404 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged to master. |
Late LGTM. Thank you all. |
Just quick question: Do you guys know the diff between 4.8-1 vs 4.8? The official release seems to be 4.8 https://www.antlr.org/download/index.html - I checked the pom files and jars too. |
Maybe let's just use the 4.8 that's matched with the official releases there ... Thanks for pointing this out, @bozhang2820. Mind making a quick followup to match this to 4.8? |
Sure. Created #32603. |
What changes were proposed in this pull request?
This PR intends to upgrade ANTLR runtime from 4.7.1 to 4.8-1.
Why are the changes needed?
Release note of v4.8 and v4.7.2 (the v4.7.2 release has a few minor bug fixes for java targets):
Does this PR introduce any user-facing change?
No.
How was this patch tested?
GA tests.