[SPARK-35535][SQL] New data source V2 API: LocalScan #32678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
|
Test build #138986 has finished for PR 32678 at commit
|
|
Thank you for pinging me, @gengliangwang . |
HyukjinKwon
approved these changes
May 27, 2021
viirya
reviewed
May 27, 2021
sql/core/src/main/java/org/apache/spark/sql/connector/read/LocalScan.java
Show resolved
Hide resolved
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
cloud-fan
reviewed
May 27, 2021
...core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
May 27, 2021
viirya
approved these changes
May 27, 2021
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #139008 has finished for PR 32678 at commit
|
|
Merged to master. |
|
Test build #139015 has finished for PR 32678 at commit
|
|
+1, late LGTM. Thanks! |
huaxingao
pushed a commit
to huaxingao/spark
that referenced
this pull request
Jun 9, 2021
### What changes were proposed in this pull request? Add a new data source V2 API: `LocalScan`. It is a special Scan that will happen on Driver locally instead of Executors. ### Why are the changes needed? The new API improves the flexibility of the DSV2 API. It allows developers to implement connectors for data sources of small data sizes. For example, we can build a data source for Spark History applications from Spark History Server RESTFUL API. The result set is small and fetching all the results from the Spark driver is good enough. Making it a data source allows us to operate SQL queries with filters or table joins. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Unit test Closes apache#32678 from gengliangwang/LocalScan. Lead-authored-by: Gengliang Wang <ltnwgl@gmail.com> Co-authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 5bcd1c2)
dongjoon-hyun
pushed a commit
that referenced
this pull request
Aug 24, 2021
### What changes were proposed in this pull request? This is a follow-up of #32678. It moves `LocalScan` from SQL core package to Catalyst package. ### Why are the changes needed? There are two packages for `org.apache.spark.sql.connector` SQL Core: https://github.com/apache/spark/tree/master/sql/core/src/main/java/org/apache/spark/sql/connector Catalyst: https://github.com/apache/spark/tree/master/sql/catalyst/src/main/java/org/apache/spark/sql/connector As `LocalScan` doesn't depend on the classes of SQL Core, we should move it to catalyst. ### Does this PR introduce _any_ user-facing change? No, the trait is not released yet. ### How was this patch tested? Existing UT. Closes #33826 from gengliangwang/moveLocalScan. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Aug 24, 2021
### What changes were proposed in this pull request? This is a follow-up of #32678. It moves `LocalScan` from SQL core package to Catalyst package. ### Why are the changes needed? There are two packages for `org.apache.spark.sql.connector` SQL Core: https://github.com/apache/spark/tree/master/sql/core/src/main/java/org/apache/spark/sql/connector Catalyst: https://github.com/apache/spark/tree/master/sql/catalyst/src/main/java/org/apache/spark/sql/connector As `LocalScan` doesn't depend on the classes of SQL Core, we should move it to catalyst. ### Does this PR introduce _any_ user-facing change? No, the trait is not released yet. ### How was this patch tested? Existing UT. Closes #33826 from gengliangwang/moveLocalScan. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 5b4c216) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a new data source V2 API:
LocalScan. It is a special Scan that will happen on Driver locally instead of Executors.Why are the changes needed?
The new API improves the flexibility of the DSV2 API. It allows developers to implement connectors for data sources of small data sizes.
For example, we can build a data source for Spark History applications from Spark History Server RESTFUL API. The result set is small and fetching all the results from the Spark driver is good enough. Making it a data source allows us to operate SQL queries with filters or table joins.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test