[SPARK-35535][SQL][FOLLOWUP] Move LocalScan to Catalyst package #33826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't notice the difference when making the PR. Let's fix it before the 3.2 release. |
cloud-fan
approved these changes
Aug 24, 2021
viirya
approved these changes
Aug 24, 2021
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
dongjoon-hyun
approved these changes
Aug 24, 2021
dongjoon-hyun
pushed a commit
that referenced
this pull request
Aug 24, 2021
### What changes were proposed in this pull request? This is a follow-up of #32678. It moves `LocalScan` from SQL core package to Catalyst package. ### Why are the changes needed? There are two packages for `org.apache.spark.sql.connector` SQL Core: https://github.com/apache/spark/tree/master/sql/core/src/main/java/org/apache/spark/sql/connector Catalyst: https://github.com/apache/spark/tree/master/sql/catalyst/src/main/java/org/apache/spark/sql/connector As `LocalScan` doesn't depend on the classes of SQL Core, we should move it to catalyst. ### Does this PR introduce _any_ user-facing change? No, the trait is not released yet. ### How was this patch tested? Existing UT. Closes #33826 from gengliangwang/moveLocalScan. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 5b4c216) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Merged to master/3.2. |
|
Test build #142734 has finished for PR 33826 at commit
|
|
lgtm2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of #32678. It moves
LocalScanfrom SQL core package to Catalyst package.Why are the changes needed?
There are two packages for
org.apache.spark.sql.connectorSQL Core: https://github.com/apache/spark/tree/master/sql/core/src/main/java/org/apache/spark/sql/connector
Catalyst: https://github.com/apache/spark/tree/master/sql/catalyst/src/main/java/org/apache/spark/sql/connector
As
LocalScandoesn't depend on the classes of SQL Core, we should move it to catalyst.Does this PR introduce any user-facing change?
No, the trait is not released yet.
How was this patch tested?
Existing UT.