Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-35582][PYTHON][DOCS] Remove # noqa in Python API documents. #32728

Closed
wants to merge 1 commit into from
Closed

[SPARK-35582][PYTHON][DOCS] Remove # noqa in Python API documents. #32728

wants to merge 1 commit into from

Conversation

itholic
Copy link
Contributor

@itholic itholic commented Jun 1, 2021

What changes were proposed in this pull request?

This PR aims to move # noqa in the Python docstring to the proper place so that hide them from the official documents.

Why are the changes needed?

If we don't move # noqa to the proper place, it is exposed in the middle of the docstring, and it looks a bit wired as below:
Screen Shot 2021-06-01 at 3 17 52 PM

Does this PR introduce any user-facing change?

Yes, the # noqa is no more shown in the documents as below:
Screen Shot 2021-06-01 at 3 21 00 PM

How was this patch tested?

Manually build docs and check.

@itholic
Copy link
Contributor Author

itholic commented Jun 1, 2021

There is only one case remaining in the schema_of_json since other cases are all resolved in the previous PR.

Please refer to: 3bda8db

@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants