-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow sequences (tuples and lists) as pivot values argument in PySpark. #33083
Conversation
Both tuples and lists are accepted by PySpark on runtime.
Jenkins ok to test |
This looks reasonable to me, I'm not very familiar with the typing code for Python yet so cc @zero323 |
Test build #140338 has finished for PR 33083 at commit
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
Technically speaking, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, subject to passing tests.
Can one of the admins verify this patch? |
@wrobell, can you file a JIRA (see https://spark.apache.org/contributing.html), and enable GitHub Actions in your fork repo (see https://github.com/apache/spark/pull/33083/checks?check_run_id=2913538608)? Also please keep the GIthub PR template (https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE) and format PR title properly. |
Otherwise, looks fine to me too. I'll leave it to him. |
Sure, I'll handle this once pending comments are addressed. |
Gentle ping @wrobell |
Sorry, but due to personal circumstances I will not be able to help with this for next couple of weeks. |
any update here? python/pyspark/sql/group.pyi has been removed by #34197, so can I create a JIRA ticket and a PR for this issue? @HyukjinKwon @zero323 @wrobell |
Both tuples and lists are accepted by PySpark on runtime.