Skip to content

[SPARK-36938][PYTHON] Inline type hints for group.py in python/pyspark/sql#34197

Closed
dchvn wants to merge 4 commits intoapache:masterfrom
dchvn:SPARK-36938
Closed

[SPARK-36938][PYTHON] Inline type hints for group.py in python/pyspark/sql#34197
dchvn wants to merge 4 commits intoapache:masterfrom
dchvn:SPARK-36938

Conversation

@dchvn
Copy link
Contributor

@dchvn dchvn commented Oct 6, 2021

What changes were proposed in this pull request?

Inline type hints for python/pyspark/sql/group.py from Inline type hints for python/pyspark/sql/group.pyi.

Why are the changes needed?

Currently, there is type hint stub files python/pyspark/sql/group.pyi to show the expected types for functions, but we can also take advantage of static type checking within the functions by inlining the type hints.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existed test.

@dchvn dchvn changed the title [SPARK-36938][PYTHON] Inline type hints for group.py in python/pyspar… [SPARK-36938][PYTHON] Inline type hints for group.py in python/pyspark/sql Oct 6, 2021
@SparkQA
Copy link

SparkQA commented Oct 6, 2021

Test build #143880 has finished for PR 34197 at commit b331cc8.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 6, 2021

Test build #143878 has finished for PR 34197 at commit 5c732ab.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dchvn
Copy link
Contributor Author

dchvn commented Oct 6, 2021

CC @HyukjinKwon @ueshin @zero323 @xinrong-databricks Please help me review this PR

@SparkQA
Copy link

SparkQA commented Oct 6, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48391/

@SparkQA
Copy link

SparkQA commented Oct 6, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48393/

@SparkQA
Copy link

SparkQA commented Oct 6, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48391/

@SparkQA
Copy link

SparkQA commented Oct 6, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48393/

@SparkQA
Copy link

SparkQA commented Oct 13, 2021

Test build #144174 has finished for PR 34197 at commit 514a6f1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 13, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48652/

@SparkQA
Copy link

SparkQA commented Oct 13, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48652/

@SparkQA
Copy link

SparkQA commented Oct 14, 2021

Test build #144221 has finished for PR 34197 at commit 6ff504e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 14, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48701/

@SparkQA
Copy link

SparkQA commented Oct 14, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48701/

@ueshin
Copy link
Member

ueshin commented Oct 14, 2021

Thanks! merging to master.

@ueshin ueshin closed this in bb83f27 Oct 14, 2021
@dchvn
Copy link
Contributor Author

dchvn commented Oct 15, 2021

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants