Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-35901][PYTHON] Refine type hints in pyspark.pandas.window #33097

Closed
wants to merge 1 commit into from

Conversation

ueshin
Copy link
Member

@ueshin ueshin commented Jun 26, 2021

What changes were proposed in this pull request?

Refines type hints in pyspark.pandas.window.

Also, some refactoring is included to clean up the type hierarchy of Rolling and Expanding.

Why are the changes needed?

We can use more strict type hints for functions in pyspark.pandas.window using the generic way.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests.

@SparkQA
Copy link

SparkQA commented Jun 26, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44883/

@SparkQA
Copy link

SparkQA commented Jun 26, 2021

Test build #140352 has finished for PR 33097 at commit 53febc2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class RollingAndExpanding(Generic[T_Frame], metaclass=ABCMeta):
  • class RollingLike(RollingAndExpanding[T_Frame]):
  • class Rolling(RollingLike[T_Frame]):
  • class RollingGroupby(RollingLike[T_Frame]):
  • class ExpandingLike(RollingAndExpanding[T_Frame]):
  • class Expanding(ExpandingLike[T_Frame]):
  • class ExpandingGroupby(ExpandingLike[T_Frame]):

@SparkQA
Copy link

SparkQA commented Jun 26, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44883/

@ueshin ueshin marked this pull request as ready for review June 26, 2021 04:11
@HyukjinKwon
Copy link
Member

Merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants