[SPARK-35916][SQL] Support subtraction among Date/Timestamp/TimestampWithoutTZ #33115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
Jun 28, 2021
sql/catalyst/src/main/scala/org/apache/spark/sql/types/AbstractDataType.scala
Show resolved
Hide resolved
cloud-fan
reviewed
Jun 28, 2021
| @@ -386,8 +386,8 @@ class Analyzer(override val catalogManager: CatalogManager) | |||
| DatetimeSub(l, r, DateAddInterval(l, UnaryMinus(r, f), ansiEnabled = f)) | |||
| case (_, CalendarIntervalType | _: DayTimeIntervalType) => | |||
| Cast(DatetimeSub(l, r, TimeAdd(l, UnaryMinus(r, f))), l.dataType) | |||
| case (TimestampType, _) => SubtractTimestamps(l, r) | |||
| case (_, TimestampType) => SubtractTimestamps(l, r) | |||
| case (TimestampType | TimestampWithoutTZType, _) => SubtractTimestamps(l, r) | |||
There was a problem hiding this comment.
Can this be case (AnyTimestampType(), _)?
There was a problem hiding this comment.
No. But we can simplify it with
case _ if AnyTimestampType.unapply(l) || AnyTimestampType.unapply(r) =>
cloud-fan
reviewed
Jun 28, 2021
cloud-fan
approved these changes
Jun 28, 2021
|
Merging to master |
gengliangwang
added a commit
that referenced
this pull request
Jun 29, 2021
### What changes were proposed in this pull request? Replace the type collection `AllTimestampTypes` with the new data type `AnyTimestampType` ### Why are the changes needed? As discussed in #33115 (comment), it is more convenient to have a new data type "AnyTimestampType" instead of using type collection `AllTimestampTypes`: 1. simplify the pattern match 2. In the default type coercion rules, when implicit casting a type to a TypeCollection type, Spark chooses the first convertible data type as the result. If we are going to make the default timestamp type configurable, having AnyTimestampType is better ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing UT Closes #33129 from gengliangwang/allTimestampTypes. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Gengliang Wang <gengliang@apache.org>
|
Refer to this link for build results (access rights to CI server needed): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support the following operations:
For subtraction between
TimestampWithoutTZandTimestamp, theTimestampcolumn is cast as TimestampWithoutTZType.Why are the changes needed?
Support basic subtraction among Date/Timestamp/TimestampWithoutTZ.
Does this PR introduce any user-facing change?
No, the timestamp without time zone type is not release yet.
How was this patch tested?
Unit tests