Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-35927][SQL] Remove type collection AllTimestampTypes #33129

Closed
wants to merge 1 commit into from

Conversation

gengliangwang
Copy link
Member

What changes were proposed in this pull request?

Replace the type collection AllTimestampTypes with the new data type AnyTimestampType

Why are the changes needed?

As discussed in #33115 (comment), it is more convenient to have a new data type "AnyTimestampType" instead of using type collection AllTimestampTypes:

  1. simplify the pattern match
  2. In the default type coercion rules, when implicit casting a type to a TypeCollection type, Spark chooses the first convertible data type as the result. If we are going to make the default timestamp type configurable, having AnyTimestampType is better

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing UT

@gengliangwang
Copy link
Member Author

Merging to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants