-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-36760][SQL][FOLLOWUP] Add interface SupportsPushDownV2Filters #34073
Conversation
* | ||
* @since 3.3.0 | ||
*/ | ||
@Evolving | ||
public interface SupportsPushDownV2Filters extends ScanBuilder { | ||
|
||
/** | ||
* Pushes down filters, and returns filters that need to be evaluated after scanning. | ||
* Pushes down data source V2 filters, and returns V2 filters that need to be evaluated after | ||
* scanning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cloud-fan Please let me know how you want to document this.
Kubernetes integration test starting |
Kubernetes integration test status failure |
Test build #143523 has finished for PR 34073 at commit
|
sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/SupportsPushDownV2Filters.java
Show resolved
Hide resolved
Kubernetes integration test starting |
Kubernetes integration test status failure |
Test build #143532 has finished for PR 34073 at commit
|
thanks, merging to master! |
Thanks! |
This change seems to break the build.
Please let me fix it. |
### What changes were proposed in this pull request? This PR fixes a JavaDoc style error introduced in SPARK-36760 (#34073). Due to this error, build on GA fails and the following error message appears. ``` [error] * internal -> external data conversion. ``` ### Why are the changes needed? To recover GA. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Should be done by GA itself. Closes #34078 from sarutak/fix-doc-error. Authored-by: Kousuke Saruta <sarutak@oss.nttdata.com> Signed-off-by: Kousuke Saruta <sarutak@oss.nttdata.com>
What changes were proposed in this pull request?
update java doc...
Why are the changes needed?
to highlight the difference between this new interface
SupportsPushDownV2Filters
and the old oneSupportsPushDownFilters
Does this PR introduce any user-facing change?
No
How was this patch tested?
Test not needed