Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-36760][SQL][FOLLOWUP] Add interface SupportsPushDownV2Filters #34073

Closed
wants to merge 2 commits into from

Conversation

huaxingao
Copy link
Contributor

What changes were proposed in this pull request?

update java doc...

Why are the changes needed?

to highlight the difference between this new interface SupportsPushDownV2Filters and the old one SupportsPushDownFilters

Does this PR introduce any user-facing change?

No

How was this patch tested?

Test not needed

@github-actions github-actions bot added the SQL label Sep 22, 2021
*
* @since 3.3.0
*/
@Evolving
public interface SupportsPushDownV2Filters extends ScanBuilder {

/**
* Pushes down filters, and returns filters that need to be evaluated after scanning.
* Pushes down data source V2 filters, and returns V2 filters that need to be evaluated after
* scanning.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cloud-fan Please let me know how you want to document this.

@SparkQA
Copy link

SparkQA commented Sep 22, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48031/

@SparkQA
Copy link

SparkQA commented Sep 23, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48031/

@SparkQA
Copy link

SparkQA commented Sep 23, 2021

Test build #143523 has finished for PR 34073 at commit 1014995.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 23, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48040/

@SparkQA
Copy link

SparkQA commented Sep 23, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48040/

@SparkQA
Copy link

SparkQA commented Sep 23, 2021

Test build #143532 has finished for PR 34073 at commit 3a0052f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in 6e815da Sep 23, 2021
@huaxingao
Copy link
Contributor Author

Thanks!

@huaxingao huaxingao deleted the followup branch September 23, 2021 15:55
@sarutak
Copy link
Member

sarutak commented Sep 23, 2021

This change seems to break the build.

[error]  * internal -> external data conversion.

Please let me fix it.

sarutak added a commit that referenced this pull request Sep 23, 2021
### What changes were proposed in this pull request?

This PR fixes a JavaDoc style error introduced in SPARK-36760 (#34073).
Due to this error, build on GA fails and the following error message appears.
```
[error]  * internal -> external data conversion.
```

### Why are the changes needed?

To recover GA.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Should be done by GA itself.

Closes #34078 from sarutak/fix-doc-error.

Authored-by: Kousuke Saruta <sarutak@oss.nttdata.com>
Signed-off-by: Kousuke Saruta <sarutak@oss.nttdata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants