New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-36760][DOCS][FOLLOWUP] Fix wrong JavaDoc style #34078

Closed

sarutak wants to merge 1 commit into apache:master from sarutak:fix-doc-error

Member

sarutak commented Sep 23, 2021

What changes were proposed in this pull request?

This PR fixes a JavaDoc style error introduced in SPARK-36760 (#34073).
Due to this error, build on GA fails and the following error message appears.

[error]  * internal -> external data conversion.

Why are the changes needed?

To recover GA.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Should be done by GA itself.


          > -> &gt;

3037c20

github-actions bot added the SQL label

Contributor

cloud-fan commented Sep 23, 2021

Ah so java style check is only done by the Github actions. Thanks for fixing it!

cloud-fan approved these changes

View reviewed changes

huaxingao approved these changes

View reviewed changes

Member Author

sarutak commented Sep 23, 2021 •

edited

Loading

Generating documents on GA seems to succeed.
https://github.com/sarutak/spark/runs/3690271491?check_suite_focus=true#step:9:12621

So I'll merge this to master not to block other PRs.

sarutak closed this in

0b65daa

SparkQA commented Sep 23, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48064/

Contributor

huaxingao commented Sep 23, 2021

Thank you! @sarutak

SparkQA commented Sep 23, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48064/

SparkQA commented Sep 23, 2021

Test build #143555 has finished for PR 34078 at commit 3037c20.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment