Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-37108][R] Expose make_date expression in R #34480

Closed
wants to merge 5 commits into from

Conversation

yoda-mon
Copy link
Contributor

@yoda-mon yoda-mon commented Nov 4, 2021

What changes were proposed in this pull request?

Expose make_date API on SparkR

Why are the changes needed?

make_date APIs on Scala and PySpark were added by SPARK-34356, this PR aims to cover the API on SparkR.

Does this PR introduce any user-facing change?

Yes, users can call the API by SparkR

How was this patch tested?

unit tests.

@yoda-mon
Copy link
Contributor Author

yoda-mon commented Nov 4, 2021

I chose year, month, day as parameters for arguments at first.

スクリーンショット 2021-11-02 17 01 43

However, I realized some functions use those units as arguments, so I switched to use x, y, z and add y, z param declaration at column_datetime_functions section.
スクリーンショット 2021-11-03 0 49 59

Ohter functions like column_string_functions use y as second parameters.

@SparkQA
Copy link

SparkQA commented Nov 4, 2021

Test build #144888 has finished for PR 34480 at commit 1d41c89.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 4, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49358/

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @sarutak fyi

@HyukjinKwon HyukjinKwon changed the title [SPARK-37108][R]Expose make_date expression in R [SPARK-37108][R] Expose make_date expression in R Nov 4, 2021
@SparkQA
Copy link

SparkQA commented Nov 4, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49358/

@sarutak
Copy link
Member

sarutak commented Nov 4, 2021

Merging to master (Thank you @HyukjinKwon for pinging me).

@sarutak sarutak closed this in 5f997c7 Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants