Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-37004][PYTHON] Upgrade to Py4J 0.10.9.3 #34814

Closed
wants to merge 1 commit into from

Conversation

HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR upgrades Py4J from 0.10.9.2 to 0.10.9.3 which contains the bug fix (py4j/py4j#440) that directly affected us.

For example, once you cancel a cell in Jupyter, all following cells simply fail. This PR fixes the bug by upgrading Py4J.

Why are the changes needed?

To fix a regression in Spark 3.2.0 in notebooks like Jupyter.

Does this PR introduce any user-facing change?

Fixes a regression described in SPARK-37004

How was this patch tested?

Manually tested the fix when I land py4j/py4j#440 to Py4J.

@HyukjinKwon
Copy link
Member Author

This has to be backported to branch-3.2.

cc @huaxingao, @dongjoon-hyun, @mengxr, @JoshRosen FYI

@SparkQA
Copy link

SparkQA commented Dec 6, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50414/

@SparkQA
Copy link

SparkQA commented Dec 6, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50414/

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@SparkQA
Copy link

SparkQA commented Dec 6, 2021

Test build #145938 has finished for PR 34814 at commit 15bca82.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

Thanks guys.

Merged to master and branch-3.2.

HyukjinKwon added a commit that referenced this pull request Dec 6, 2021
This PR upgrades Py4J from 0.10.9.2 to 0.10.9.3 which contains the bug fix (py4j/py4j#440) that directly affected us.

For example, once you cancel a cell in Jupyter, all following cells simply fail. This PR fixes the bug by upgrading Py4J.

To fix a regression in Spark 3.2.0 in notebooks like Jupyter.

Fixes a regression described in SPARK-37004

Manually tested the fix when I land py4j/py4j#440 to Py4J.

Closes #34814 from HyukjinKwon/SPARK-37004.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit 72669b5)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
@HyukjinKwon HyukjinKwon deleted the SPARK-37004 branch January 4, 2022 00:51
catalinii pushed a commit to lyft/spark that referenced this pull request Feb 22, 2022
This PR upgrades Py4J from 0.10.9.2 to 0.10.9.3 which contains the bug fix (py4j/py4j#440) that directly affected us.

For example, once you cancel a cell in Jupyter, all following cells simply fail. This PR fixes the bug by upgrading Py4J.

To fix a regression in Spark 3.2.0 in notebooks like Jupyter.

Fixes a regression described in SPARK-37004

Manually tested the fix when I land py4j/py4j#440 to Py4J.

Closes apache#34814 from HyukjinKwon/SPARK-37004.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit 72669b5)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
catalinii pushed a commit to lyft/spark that referenced this pull request Mar 4, 2022
This PR upgrades Py4J from 0.10.9.2 to 0.10.9.3 which contains the bug fix (py4j/py4j#440) that directly affected us.

For example, once you cancel a cell in Jupyter, all following cells simply fail. This PR fixes the bug by upgrading Py4J.

To fix a regression in Spark 3.2.0 in notebooks like Jupyter.

Fixes a regression described in SPARK-37004

Manually tested the fix when I land py4j/py4j#440 to Py4J.

Closes apache#34814 from HyukjinKwon/SPARK-37004.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit 72669b5)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
kazuyukitanimura pushed a commit to kazuyukitanimura/spark that referenced this pull request Aug 10, 2022
This PR upgrades Py4J from 0.10.9.2 to 0.10.9.3 which contains the bug fix (py4j/py4j#440) that directly affected us.

For example, once you cancel a cell in Jupyter, all following cells simply fail. This PR fixes the bug by upgrading Py4J.

To fix a regression in Spark 3.2.0 in notebooks like Jupyter.

Fixes a regression described in SPARK-37004

Manually tested the fix when I land py4j/py4j#440 to Py4J.

Closes apache#34814 from HyukjinKwon/SPARK-37004.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit 72669b5)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants