[SPARK-37777][SQL] Update the SQL syntax of SHOW FUNCTIONS #35056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
commented
Dec 29, 2021
| @@ -30,7 +30,7 @@ clause is optional and supported only for compatibility with other systems. | |||
| ### Syntax | |||
|
|
|||
| ```sql | |||
| SHOW [ function_kind ] FUNCTIONS [ [ LIKE ] { function_name | regex_pattern } ] | |||
| SHOW [ function_kind ] FUNCTIONS [ { FROM | IN } database_name ] [ LIKE regex_pattern ] | |||
There was a problem hiding this comment.
I removed the document for the legacy syntax as a soft deprecation.
imback82
approved these changes
Dec 29, 2021
| ShowFunctions(nsPlan, true, true, Some("funct*"))) | ||
| comparePlans( | ||
| parsePlan("SHOW FUNCTIONS IN db LIKE 'funct*'"), | ||
| ShowFunctions(UnresolvedNamespace(Seq("db")), true, true, Some("funct*"))) | ||
| comparePlans( | ||
| parsePlan("SHOW FUNCTIONS LIKE a.b.c"), |
There was a problem hiding this comment.
Can you add a test SHOW FUNCTIONS LIKE a so that namespace becomes nsPlan?
| val sql = "SHOW other FUNCTIONS" | ||
| intercept(sql, s"$sql not supported") | ||
| intercept("SHOW FUNCTIONS IN db f1", "Invalid pattern") |
There was a problem hiding this comment.
nit: add full error message (helpful when searching for a corresponding test case)?
viirya
approved these changes
Dec 30, 2021
IIUC migration guide is for breaking changes, not new features. Since this PR doesn't break anything, we don't need to update migration guide. |
|
thanks for the review, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The SQL syntax of
SHOW FUNCTIONSis very weird today. If you want to specify the database to list functions, you need to writeSHOW FUNCTIONS LIKE db.f1. This is inconsistent withSHOW TABLESandSHOW VIEWS.This PR proposes to follow
SHOW TABLESandSHOW VIEWS, and supportSHOW FUNCTIONS FROM/IN db LIKE pattern. To keep backward compatibility, the legacy syntax is still supported, but it can't be used together with the newFROM/IN dbclause.Why are the changes needed?
Be consistent with
SHOW TABLESandSHOW VIEWSDoes this PR introduce any user-facing change?
Yea, as it extends the
SHOW FUNCTIONSSQL syntax.How was this patch tested?
updated tests