[SPARK-37817][SQL][Minor] Remove unreachable code in complexTypeExtractors.scala #35106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengliangwang
commented
Jan 5, 2022
| @@ -236,8 +236,6 @@ case class GetArrayItem( | |||
| failOnError: Boolean = SQLConf.get.strictIndexOperator) | |||
| extends BinaryExpression with GetArrayItemUtil with ExpectsInputTypes with ExtractValue { | |||
|
|
|||
| def this(child: Expression, ordinal: Expression) = this(child, ordinal, SQLConf.get.ansiEnabled) | |||
There was a problem hiding this comment.
The SQLConf.get.ansiEnabled here should be SQLConf.get.strictIndexOperator. But it doesn't matter since the code here is not reachable.
cloud-fan
approved these changes
Jan 5, 2022
|
Merging to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The constructor of GetArrayItem and GetMapValue with two input elements are not actually used. Usually, we implement such construction method so that it can be used in FunctionRegistry
Since the expression GetArrayItem and GetMapValue are not used as functions in FunctionRegistry, we can remove these constructors.
Why are the changes needed?
Code clean up
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT