[SPARK-37963][SQL] Need to update Partition URI after renaming table in InMemoryCatalog #35251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
Jan 19, 2022
| @@ -74,6 +74,16 @@ trait AlterTableRenameSuiteBase extends command.AlterTableRenameSuiteBase { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| test("preserve partition info") { | |||
There was a problem hiding this comment.
can we put the test in the base class?
HyukjinKwon
reviewed
Jan 20, 2022
| @@ -126,4 +126,14 @@ trait AlterTableRenameSuiteBase extends QueryTest with DDLCommandTestUtils { | |||
| spark.sessionState.catalogManager.reset() | |||
| } | |||
| } | |||
|
|
|||
| test("preserve partition info") { | |||
There was a problem hiding this comment.
nit but maybe we should better add JIRA prefix.
cloud-fan
approved these changes
Jan 20, 2022
|
Merging to master/3.2 |
gengliangwang
added a commit
that referenced
this pull request
Jan 20, 2022
…in InMemoryCatalog
### What changes were proposed in this pull request?
After renaming a partitioned table, select from the new table from InMemoryCatalog will get an empty result.
The following checkAnswer will fail as the result is empty.
```
sql(s"create table foo(i int, j int) using PARQUET partitioned by (j)")
sql("insert into table foo partition(j=2) values (1)")
sql(s"alter table foo rename to bar")
checkAnswer(spark.table("bar"), Row(1, 2))
```
To fix the bug, we need to update Partition URI after renaming a table in InMemoryCatalog
### Why are the changes needed?
Bug fix
### Does this PR introduce _any_ user-facing change?
No, InMemoryCatalog is used internally and HMS doesn't have this bug.
### How was this patch tested?
Unit test
Closes #35251 from gengliangwang/fixAlterRename.
Authored-by: Gengliang Wang <gengliang@apache.org>
Signed-off-by: Gengliang Wang <gengliang@apache.org>
(cherry picked from commit 851eb28)
Signed-off-by: Gengliang Wang <gengliang@apache.org>
kazuyukitanimura
pushed a commit
to kazuyukitanimura/spark
that referenced
this pull request
Aug 10, 2022
…in InMemoryCatalog
### What changes were proposed in this pull request?
After renaming a partitioned table, select from the new table from InMemoryCatalog will get an empty result.
The following checkAnswer will fail as the result is empty.
```
sql(s"create table foo(i int, j int) using PARQUET partitioned by (j)")
sql("insert into table foo partition(j=2) values (1)")
sql(s"alter table foo rename to bar")
checkAnswer(spark.table("bar"), Row(1, 2))
```
To fix the bug, we need to update Partition URI after renaming a table in InMemoryCatalog
### Why are the changes needed?
Bug fix
### Does this PR introduce _any_ user-facing change?
No, InMemoryCatalog is used internally and HMS doesn't have this bug.
### How was this patch tested?
Unit test
Closes apache#35251 from gengliangwang/fixAlterRename.
Authored-by: Gengliang Wang <gengliang@apache.org>
Signed-off-by: Gengliang Wang <gengliang@apache.org>
(cherry picked from commit 851eb28)
Signed-off-by: Gengliang Wang <gengliang@apache.org>
(cherry picked from commit 4a8e4cb)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
After renaming a partitioned table, select from the new table from InMemoryCatalog will get an empty result.
The following checkAnswer will fail as the result is empty.
To fix the bug, we need to update Partition URI after renaming a table in InMemoryCatalog
Why are the changes needed?
Bug fix
Does this PR introduce any user-facing change?
No, InMemoryCatalog is used internally and HMS doesn't have this bug.
How was this patch tested?
Unit test