Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-4663][sql]add finally to avoid resource leak #3526

Closed
wants to merge 3 commits into from
Closed

[SPARK-4663][sql]add finally to avoid resource leak #3526

wants to merge 3 commits into from

Conversation

baishuo
Copy link
Contributor

@baishuo baishuo commented Dec 1, 2014

No description provided.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@JoshRosen
Copy link
Contributor

Jenkins, this is ok to test.

@SparkQA
Copy link

SparkQA commented Dec 1, 2014

Test build #23970 has started for PR 3526 at commit ae0e447.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 1, 2014

Test build #23970 has finished for PR 3526 at commit ae0e447.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23970/
Test PASSed.

rxin
rxin reviewed Dec 1, 2014
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTableOperations.scala
writer.write(null, row)
}
}
finally {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put the finally on the same line as the previous } ? thanks.

@baishuo
Copy link
Contributor Author

baishuo commented Dec 1, 2014

@rxin no problem. Had modify it :)

@SparkQA
Copy link

SparkQA commented Dec 1, 2014

Test build #23988 has started for PR 3526 at commit b36bf96.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 1, 2014

Test build #23988 has finished for PR 3526 at commit b36bf96.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23988/
Test PASSed.

marmbrus
marmbrus reviewed Dec 1, 2014
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTableOperations.scala
writer.write(null, row)
}
} finally {
writer.close(hadoopContext)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent only 2 spaces here.

@baishuo
Copy link
Contributor Author

baishuo commented Dec 2, 2014

had modified according @marmbrus comment：)

@SparkQA
Copy link

SparkQA commented Dec 2, 2014

Test build #24017 has started for PR 3526 at commit d446e14.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 2, 2014

Test build #24017 has finished for PR 3526 at commit d446e14.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24017/
Test PASSed.

@asfgit asfgit closed this in 69b6fed Dec 2, 2014
asfgit pushed a commit that referenced this pull request Dec 2, 2014
@baishuo @marmbrus
[SPARK-4663][sql]add finally to avoid resource leak
aa3d369 
Author: baishuo <vc_java@hotmail.com>

Closes #3526 from baishuo/master-trycatch and squashes the following commits:

d446e14 [baishuo] correct the code style
b36bf96 [baishuo] correct the code style
ae0e447 [baishuo] add finally to avoid resource leak

(cherry picked from commit 69b6fed)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@marmbrus
Copy link
Contributor

marmbrus commented Dec 2, 2014

Thanks, merged to master and 1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@baishuo @AmplabJenkins @JoshRosen @SparkQA @marmbrus @rxin