[SPARK-38163][SQL] Preserve the error class of SparkThrowable
while constructing of function builder
#35467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to propagate
SparkThrowable
to user space AS IS in constructing of function builder. This allows to preserve the error class, for instance.Why are the changes needed?
This fixes the issues portrayed by the example below:
The expected error should be
ILLEGAL_SUBSTRING
. It sets atspark/sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
Line 71 in 899d3bb
Does this PR introduce any user-facing change?
Yes, the PR changes exceptions that can be handles by users.
After the changes:
How was this patch tested?
By running new test: