[SPARK-36059][K8S][FOLLOWUP] Support spark.kubernetes.scheduler.name
#35499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dongjoon-hyun this may an improvement to simplify configuration on scheduler. |
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
Outdated
Show resolved
Hide resolved
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
Outdated
Show resolved
Hide resolved
dongjoon-hyun
changed the title
spark.kubernetes.scheduler.namespark.kubernetes.scheduler.name
dongjoon-hyun
requested changes
Feb 14, 2022
|
@dongjoon-hyun Sure, thanks, will update soon. |
martin-g
approved these changes
Feb 14, 2022
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
Outdated
Show resolved
Hide resolved
|
Gentle ping, @Yikun . |
Yikun
commented
Feb 15, 2022
...rce-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
Outdated
Show resolved
Hide resolved
| @@ -42,7 +42,7 @@ private[spark] abstract class KubernetesConf(val sparkConf: SparkConf) { | |||
| def secretEnvNamesToKeyRefs: Map[String, String] | |||
| def secretNamesToMountPaths: Map[String, String] | |||
| def volumes: Seq[KubernetesVolumeSpec] | |||
| def schedulerName: String | |||
| def schedulerName: Option[String] | |||
There was a problem hiding this comment.
Since schedulerName is added at 3.3.0, it looks like a safe change.
|
@dongjoon-hyun Thanks for review. I update the test and plus doc. |
martin-g
approved these changes
Feb 16, 2022
| @@ -1332,21 +1332,30 @@ See the [configuration page](configuration.html) for information on Spark config | |||
| <td>3.3.0</td> | |||
| </tr> | |||
| <tr> | |||
| <td><code>spark.kubernetes.executor.scheduler.name<code></td> | |||
| <td><code>spark.kubernetes.executor.scheduler.name</code></td> | |||
| <td>(none)</td> | ||
| <td> | ||
| Specify the scheduler name for each executor pod. | ||
| </td> | ||
| <td>3.0.0</td> | ||
| </tr> | ||
| <tr> | ||
| <td><code>spark.kubernetes.driver.scheduler.name<code></td> | ||
| <td><code>spark.kubernetes.driver.scheduler.name</code></td> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
spark.kubernetes.scheduler.nameto support specify driver and executor scheduler togerther.Why are the changes needed?
Before this patch, we have to specify two configuration for driver and executor:
After this patch, we can specify executor and driver scheduler name by one configuration
Does this PR introduce any user-facing change?
Yes, a configuration added.
How was this patch tested?
UT