-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-36059][K8S][FOLLOWUP] Support spark.kubernetes.scheduler.name
#35499
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1332,21 +1332,30 @@ See the [configuration page](configuration.html) for information on Spark config | |
<td>3.3.0</td> | ||
</tr> | ||
<tr> | ||
<td><code>spark.kubernetes.executor.scheduler.name<code></td> | ||
<td><code>spark.kubernetes.executor.scheduler.name</code></td> | ||
<td>(none)</td> | ||
<td> | ||
Specify the scheduler name for each executor pod. | ||
</td> | ||
<td>3.0.0</td> | ||
</tr> | ||
<tr> | ||
<td><code>spark.kubernetes.driver.scheduler.name<code></td> | ||
<td><code>spark.kubernetes.driver.scheduler.name</code></td> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto. |
||
<td>(none)</td> | ||
<td> | ||
Specify the scheduler name for driver pod. | ||
</td> | ||
<td>3.3.0</td> | ||
</tr> | ||
<tr> | ||
<td><code>spark.kubernetes.scheduler.name</code></td> | ||
<td>(none)</td> | ||
<td> | ||
Specify the scheduler name for driver and executor pods. If `spark.kubernetes.driver.scheduler.name` or | ||
`spark.kubernetes.executor.scheduler.name` is set, will override this. | ||
</td> | ||
<td>3.3.0</td> | ||
</tr> | ||
<tr> | ||
<td><code>spark.kubernetes.configMap.maxSize</code></td> | ||
<td><code>1572864</code></td> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,7 +42,7 @@ private[spark] abstract class KubernetesConf(val sparkConf: SparkConf) { | |
def secretEnvNamesToKeyRefs: Map[String, String] | ||
def secretNamesToMountPaths: Map[String, String] | ||
def volumes: Seq[KubernetesVolumeSpec] | ||
def schedulerName: String | ||
def schedulerName: Option[String] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since |
||
def appId: String | ||
|
||
def appName: String = get("spark.app.name", "spark") | ||
|
@@ -136,7 +136,9 @@ private[spark] class KubernetesDriverConf( | |
KubernetesVolumeUtils.parseVolumesWithPrefix(sparkConf, KUBERNETES_DRIVER_VOLUMES_PREFIX) | ||
} | ||
|
||
override def schedulerName: String = get(KUBERNETES_DRIVER_SCHEDULER_NAME).getOrElse("") | ||
override def schedulerName: Option[String] = { | ||
Option(get(KUBERNETES_DRIVER_SCHEDULER_NAME).getOrElse(get(KUBERNETES_SCHEDULER_NAME).orNull)) | ||
} | ||
} | ||
|
||
private[spark] class KubernetesExecutorConf( | ||
|
@@ -195,7 +197,9 @@ private[spark] class KubernetesExecutorConf( | |
KubernetesVolumeUtils.parseVolumesWithPrefix(sparkConf, KUBERNETES_EXECUTOR_VOLUMES_PREFIX) | ||
} | ||
|
||
override def schedulerName: String = get(KUBERNETES_EXECUTOR_SCHEDULER_NAME).getOrElse("") | ||
override def schedulerName: Option[String] = { | ||
Option(get(KUBERNETES_EXECUTOR_SCHEDULER_NAME).getOrElse(get(KUBERNETES_SCHEDULER_NAME).orNull)) | ||
} | ||
|
||
private def checkExecutorEnvKey(key: String): Boolean = { | ||
// Pattern for matching an executorEnv key, which meets certain naming rules. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!