Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-38347][SQL] Fix nullability propagation in transformUpWithNewOutput #35677

Closed
wants to merge 2 commits into from

Conversation

sigmod
Copy link
Contributor

@sigmod sigmod commented Feb 28, 2022

What changes were proposed in this pull request?

In updateAttr, let the new Attribute have the same nullability as the Attribute to be replaced.

Why are the changes needed?

attrMap can possibly be populated below an outer join and the outer join changes nullability.

How was this patch tested?

New unit test - verified that it fails without the fix.

@github-actions github-actions bot added the SQL label Feb 28, 2022
@sigmod
Copy link
Contributor Author

sigmod commented Feb 28, 2022

@HyukjinKwon HyukjinKwon changed the title [SPARK-38347] Fix nullability propagation in transformUpWithNewOutput [SPARK-38347][SQL] Fix nullability propagation in transformUpWithNewOutput Feb 28, 2022
Copy link
Contributor

@cloud-fan cloud-fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@gengliangwang
Copy link
Member

Thanks, merging to master/3.2

@gengliangwang
Copy link
Member

@sigmod the code changes can't apply on branch-3.2 directly. Could you open a new PR for branch-3.2?

@sigmod
Copy link
Contributor Author

sigmod commented Feb 28, 2022

@sigmod the code changes can't apply on branch-3.2 directly. Could you open a new PR for branch-3.2?

Here you go: #35685.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants