[SPARK-38347][SQL] Fix nullability propagation in transformUpWithNewOutput #35685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengliangwang
approved these changes
Mar 1, 2022
|
Thanks, merging to branch-3.2 |
gengliangwang
pushed a commit
that referenced
this pull request
Mar 1, 2022
…utput ### What changes were proposed in this pull request? In `updateAttr`, let the new Attribute have the same nullability as the Attribute to be replaced. ### Why are the changes needed? `attrMap` can possibly be populated below an outer join and the outer join changes nullability. ### How was this patch tested? New unit test - verified that it fails without the fix. Closes #35685 from sigmod/nullability2. Authored-by: Yingyi Bu <yingyi.bu@databricks.com> Signed-off-by: Gengliang Wang <gengliang@apache.org>
kazuyukitanimura
pushed a commit
to kazuyukitanimura/spark
that referenced
this pull request
Aug 10, 2022
…utput ### What changes were proposed in this pull request? In `updateAttr`, let the new Attribute have the same nullability as the Attribute to be replaced. ### Why are the changes needed? `attrMap` can possibly be populated below an outer join and the outer join changes nullability. ### How was this patch tested? New unit test - verified that it fails without the fix. Closes apache#35685 from sigmod/nullability2. Authored-by: Yingyi Bu <yingyi.bu@databricks.com> Signed-off-by: Gengliang Wang <gengliang@apache.org> (cherry picked from commit dba6edb) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In
updateAttr, let the new Attribute have the same nullability as the Attribute to be replaced.Why are the changes needed?
attrMapcan possibly be populated below an outer join and the outer join changes nullability.How was this patch tested?
New unit test - verified that it fails without the fix.