-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-38104][SQL] Migrate parsing errors of window into the new error framework #35718
Conversation
@MaxGekk Could you review this? Thanks in advance. |
Also cc @cloud-fan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except of a comment.
|""".stripMargin) | ||
} | ||
|
||
test("SPARK:38104: INVALID_SQL_SYNTAX- invalid window reference") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, follow the existing convention for test titles in the file:
test("SPARK:38104: INVALID_SQL_SYNTAX- invalid window reference") { | |
test("INVALID_SQL_SYNTAX: invalid window reference") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MaxGekk thanks for the review. fixed.
@yutoacts The failure is related to your changes:
Could you fix it, please. |
+1, LGTM. Merging to master. |
What changes were proposed in this pull request?
In this PR, I migrated parsing errors of window listed below into the new error framework.
Why are the changes needed?
Porting the parsing errors of window into the new error framework should improve user experience with Spark SQL.
Does this PR introduce any user-facing change?
Yes, it changes the error message.
How was this patch tested?
$ build/sbt "test:testOnly *QueryParsingErrorsSuite"