[SPARK-38285][SQL] Avoid generator pruning for invalid extractor #35749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| withTempView("v1") { | ||
| val sqlText = | ||
| """ | ||
| |create or replace temp view v1 as |
There was a problem hiding this comment.
nit. Shall we capitalize the SQL keywords? :)
| |""".stripMargin | ||
| sql(sqlText) | ||
|
|
||
| val df = sql("select eo.b.e from (select explode(o) as eo from v1)") |
| @@ -372,6 +372,13 @@ object GeneratorNestedColumnAliasing { | |||
| e.withNewChildren(Seq(extractor)) | |||
| } | |||
|
|
|||
| val invalidExtractor = rewrittenG.generator.children.head.collect { | |||
There was a problem hiding this comment.
Could you add some comments for this logic?
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Mar 7, 2022
|
+1, LGTM. Thank you, @viirya ! |
|
Thank you @dongjoon-hyun ! |
|
Merging to master/3.2. |
viirya
added a commit
that referenced
this pull request
Mar 7, 2022
### What changes were proposed in this pull request? This fixes a bug in generator nested column pruning. The bug happens when the extractor pattern is like `GetArrayStructFields(GetStructField(...), ...)` on the generator output. Once the input to the generator is an array, after replacing with the extractor based on pruning logic, it becomes an extractor of `GetArrayStructFields(GetArrayStructFields(...), ...)` which is not valid. ### Why are the changes needed? To fix a bug in generator nested column pruning. ### Does this PR introduce _any_ user-facing change? Yes, fixing a user-facing bug. ### How was this patch tested? Added unit test. Closes #35749 from viirya/SPARK-38285. Authored-by: Liang-Chi Hsieh <viirya@gmail.com> Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com> (cherry picked from commit 71991f7) Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
kazuyukitanimura
pushed a commit
to kazuyukitanimura/spark
that referenced
this pull request
Aug 10, 2022
### What changes were proposed in this pull request? This fixes a bug in generator nested column pruning. The bug happens when the extractor pattern is like `GetArrayStructFields(GetStructField(...), ...)` on the generator output. Once the input to the generator is an array, after replacing with the extractor based on pruning logic, it becomes an extractor of `GetArrayStructFields(GetArrayStructFields(...), ...)` which is not valid. ### Why are the changes needed? To fix a bug in generator nested column pruning. ### Does this PR introduce _any_ user-facing change? Yes, fixing a user-facing bug. ### How was this patch tested? Added unit test. Closes apache#35749 from viirya/SPARK-38285. Authored-by: Liang-Chi Hsieh <viirya@gmail.com> Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com> (cherry picked from commit 71991f7) Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com> (cherry picked from commit 8cee32d) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This fixes a bug in generator nested column pruning. The bug happens when the extractor pattern is like
GetArrayStructFields(GetStructField(...), ...)on the generator output. Once the input to the generator is an array, after replacing with the extractor based on pruning logic, it becomes an extractor ofGetArrayStructFields(GetArrayStructFields(...), ...)which is not valid.Why are the changes needed?
To fix a bug in generator nested column pruning.
Does this PR introduce any user-facing change?
Yes, fixing a user-facing bug.
How was this patch tested?
Added unit test.