[SPARK-38776][MLLIB][TESTS] Disable ANSI_ENABLED explicitly in ALSSuite
#36051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alidate input dataset' test case
dongjoon-hyun
changed the title
ALSSuite
gengliangwang
approved these changes
Apr 3, 2022
|
@dongjoon-hyun thanks for fixing it! |
yaooqinn
approved these changes
Apr 3, 2022
|
Thank you, @gengliangwang , @srowen , @yaooqinn . Merged to master/3.3. |
dongjoon-hyun
added a commit
that referenced
this pull request
Apr 3, 2022
…ite`
This PR aims to disable `ANSI_ENABLED` explicitly in the following tests of `ALSSuite`.
```
test("ALS validate input dataset") {
test("input type validation") {
```
After SPARK-38490, this test became flaky in ANSI mode GitHub Action.
- https://github.com/apache/spark/runs/5800714463?check_suite_focus=true
- https://github.com/apache/spark/runs/5803714260?check_suite_focus=true
- https://github.com/apache/spark/runs/5803745768?check_suite_focus=true
```
[info] ALSSuite:
...
[info] - ALS validate input dataset *** FAILED *** (2 seconds, 449 milliseconds)
[info] Invalid Long: out of range "Job aborted due to stage failure: Task 0 in stage 100.0 failed 1 times, most recent failure: Lost task 0.0 in stage 100.0 (TID 348) (localhost executor driver):
org.apache.spark.SparkArithmeticException:
Casting 1231000000000 to int causes overflow.
To return NULL instead, use 'try_cast'.
If necessary set spark.sql.ansi.enabled to false to bypass this error.
```
No. This is a test-only bug and fix.
Pass the CIs.
Closes #36051 from dongjoon-hyun/SPARK-38776.
Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit d18fd7b)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Oops. I realized that more |
dongjoon-hyun
added a commit
that referenced
this pull request
Apr 3, 2022
…Out of Range` failures ### What changes were proposed in this pull request? This is a follow-up of #36051. After fixing `Overflow` errors, `Out Of Range` failures are observed in the rest of test code in the same test case. ### Why are the changes needed? To make GitHub Action ANSI test CI pass. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? At this time, I used the following to simulate GitHub Action ANSI job. ``` $ SPARK_ANSI_SQL_MODE=true build/sbt "mllib/testOnly *.ALSSuite" ... [info] All tests passed. [success] Total time: 80 s (01:20), completed Apr 3, 2022 1:05:50 PM ``` Closes #36054 from dongjoon-hyun/SPARK-38776-2. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Apr 3, 2022
…Out of Range` failures This is a follow-up of #36051. After fixing `Overflow` errors, `Out Of Range` failures are observed in the rest of test code in the same test case. To make GitHub Action ANSI test CI pass. No. At this time, I used the following to simulate GitHub Action ANSI job. ``` $ SPARK_ANSI_SQL_MODE=true build/sbt "mllib/testOnly *.ALSSuite" ... [info] All tests passed. [success] Total time: 80 s (01:20), completed Apr 3, 2022 1:05:50 PM ``` Closes #36054 from dongjoon-hyun/SPARK-38776-2. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit fbcab01) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to disable
ANSI_ENABLEDexplicitly in the following tests ofALSSuite.Why are the changes needed?
After SPARK-38490, this test became flaky in ANSI mode GitHub Action.
Does this PR introduce any user-facing change?
No. This is a test-only bug and fix.
How was this patch tested?
Pass the CIs.