[SPARK-38776][MLLIB][TESTS][FOLLOWUP] Disable ANSI_ENABLED more for Out of Range failures
#36054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Out of Range` failures
|
cc @gengliangwang , @srowen , @yaooqinn |
srowen
approved these changes
Apr 3, 2022
|
Thank you, @srowen . This is a single test suite only change, and I verified in two ways. Merged to master/3.3. |
dongjoon-hyun
added a commit
that referenced
this pull request
Apr 3, 2022
…Out of Range` failures This is a follow-up of #36051. After fixing `Overflow` errors, `Out Of Range` failures are observed in the rest of test code in the same test case. To make GitHub Action ANSI test CI pass. No. At this time, I used the following to simulate GitHub Action ANSI job. ``` $ SPARK_ANSI_SQL_MODE=true build/sbt "mllib/testOnly *.ALSSuite" ... [info] All tests passed. [success] Total time: 80 s (01:20), completed Apr 3, 2022 1:05:50 PM ``` Closes #36054 from dongjoon-hyun/SPARK-38776-2. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit fbcab01) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of #36051.
After fixing
Overflowerrors,Out Of Rangefailures are observed in the rest of test code in the same test case.Why are the changes needed?
To make GitHub Action ANSI test CI pass.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
At this time, I used the following to simulate GitHub Action ANSI job.