[SPARK-38784][CORE] Upgrade Jetty to 9.4.46 #36229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
previously approved these changes
Apr 17, 2022
| @@ -139,7 +139,7 @@ | |||
| <derby.version>10.14.2.0</derby.version> | |||
| <parquet.version>1.12.2</parquet.version> | |||
| <orc.version>1.7.4</orc.version> | |||
| <jetty.version>9.4.44.v20210927</jetty.version> | |||
| <jetty.version>9.4.46.v20220331</jetty.version> | |||
There was a problem hiding this comment.
Oh, could you update the dependency manifest?
There was a problem hiding this comment.
Oops, I thought it didn't generate changes when I ran, but it does. (Actually it caused a bunch of unrelated changes in the hadoop 2 profile, but I reverted those.) Added.
There was a problem hiding this comment.
Yes, it was a bug of Apache Maven 3.8.5. If you use the latest version (like Home-brew maven), it ignores the dependency from profiles. Recently, I uninstalled man from Homebrew and use build/mvnw always to avoid that issue.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Apr 17, 2022
### What changes were proposed in this pull request? Upgrade Jetty to 9.4.46 ### Why are the changes needed? Three CVEs, which don't necessarily appear to affect Spark, are fixed in this version. Just housekeeping. CVE-2021-28169 CVE-2021-34428 CVE-2021-34429 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing tests Closes #36229 from srowen/SPARK-38784. Authored-by: Sean Owen <srowen@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 619b7b4) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Upgrade Jetty to 9.4.46
Why are the changes needed?
Three CVEs, which don't necessarily appear to affect Spark, are fixed in this version. Just housekeeping.
CVE-2021-28169
CVE-2021-34428
CVE-2021-34429
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests