[SPARK-38971][PYTHON][TESTS] Test anchor frame for in-place Series.rename_axis
#36269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinrong-meng
commented
Apr 19, 2022
| pser.rename_axis("index2", inplace=True) | ||
| psser.rename_axis("index2", inplace=True) | ||
| self.assert_eq(pser.sort_index(), psser.sort_index()) | ||
| # Note: in pandas, pdf.x's index is renamed, whereas pdf's index isn't due to a bug. |
There was a problem hiding this comment.
The code block has to be tested last since in-place rename_axis on pdf changes pdf.x accidentally.
See pandas-dev/pandas#46807.
xinrong-meng
changed the title
Series.rename_axisSeries.rename_axis
|
@ueshin @HyukjinKwon @itholic Thanks! |
HyukjinKwon
approved these changes
Apr 21, 2022
|
Merged to master. |
HyukjinKwon
changed the title
Series.rename_axisSeries.rename_axis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Test anchor frame for in-place
Series.rename_axis.Why are the changes needed?
As a follow-up for #36250, we should ensure the in-place
rename_axison Series doesn't change its anchor frame.Does this PR introduce any user-facing change?
No. Test only.
How was this patch tested?
Unit test.