[SPARK-38940][PYTHON] Test Series' anchor frame for in-place updates on Series#36250
Closed
xinrong-meng wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-38940][PYTHON] Test Series' anchor frame for in-place updates on Series#36250xinrong-meng wants to merge 1 commit intoapache:masterfrom
xinrong-meng wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
Note that |
Member
Author
|
@ueshin @HyukjinKwon @itholic Thank you! Please refer to https://github.com/xinrong-databricks/spark/actions/runs/2186563996 for test results. |
HyukjinKwon
approved these changes
Apr 19, 2022
Member
|
Merged to master. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Apr 21, 2022
…ename_axis` ### What changes were proposed in this pull request? Test anchor frame for in-place `Series.rename_axis`. ### Why are the changes needed? As a follow-up for #36250, we should ensure the in-place `rename_axis` on Series doesn't change its anchor frame. ### Does this PR introduce _any_ user-facing change? No. Test only. ### How was this patch tested? Unit test. Closes #36269 from xinrong-databricks/series.rename_axis. Authored-by: Xinrong Meng <xinrong.meng@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Test Series' anchor DataFrame for in-place updates on Series.
Why are the changes needed?
In pandas, some in-place updates on Series change its anchor frame (e.g.
Series.clip), while others don't.We should test that to ensure parity with pandas.
Example on changed anchor DataFrame
Example on unchanged anchor DataFrame
Does this PR introduce any user-facing change?
No. Test only.
How was this patch tested?
Unit tests.