[SPARK-38999][SQL] Refactor FileSourceScanExec: file scan physical node
#36327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cloud-fan @gengliangwang Can you please help review this? |
|
Can one of the admins verify this patch? |
HyukjinKwon
reviewed
Apr 25, 2022
| } ++ staticMetrics | ||
| } | ||
|
|
||
| lazy val inputRDD: RDD[InternalRow] = { |
There was a problem hiding this comment.
I like this idea of separating planning/metrics stuff vs RDD/execution.
cloud-fan
reviewed
Apr 25, 2022
| // Number of coalesced buckets. | ||
| def optionalNumCoalescedBuckets: Option[Int] | ||
| // Output attributes of the scan, including data attributes and partition attributes. | ||
| def output: Seq[Attribute] |
There was a problem hiding this comment.
DataSourceScanExec extends LeafExecNode, and def output: Seq[Attribute] is already declared there.
cloud-fan
reviewed
Apr 25, 2022
| // Output attributes of the scan, including data attributes and partition attributes. | ||
| def output: Seq[Attribute] | ||
| // Predicates to use for partition pruning. | ||
| def partitionFilters: Seq[Expression] |
There was a problem hiding this comment.
nit: can we put it near dataFilters?
cloud-fan
approved these changes
Apr 25, 2022
|
thanks, merging to master! |
LuciferYang
reviewed
Apr 25, 2022
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The PR refactors
FileSourceScanExeccase class into a base traitFileSourceScanLikewhich is then subclassed byFileSourceScanExec.FileSourceScanLikecontains basic functionality like metrics and file listing while theFileSourceScanExeccontains execution specific code.Why are the changes needed?
Currently the code for
FileSourceScanExecclass, the physical node for the file scans is quite complex and lengthy making it slightly difficult to reason about.Does this PR introduce any user-facing change?
No
How was this patch tested?
Code refactor, existing tests should suffice.