[SPARK-39907][PS] Implement axis and skipna of Series.argmin #37328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @itholic @xinrong-meng @ueshin FYI |
Yikun
reviewed
Jul 29, 2022
python/pyspark/pandas/series.py
Outdated
| axis : {{None}} | ||
| Dummy argument for consistency with Series. | ||
| skipna : bool, default True | ||
| Exclude NA/null values. If the entire Series is NA, the result |
There was a problem hiding this comment.
If the entire Series is NA, the result
It seems a plus doc for pandas (1.4.3), do we want to add a test for this?
[1] https://pandas.pydata.org/docs/reference/api/pandas.Series.argmin.html
There was a problem hiding this comment.
it results -1, not NA.
this behavior is the same as Pandas.
good catch!
|
otherwise LGTM! Thanks |
zhengruifeng
commented
Jul 29, 2022
| self.assert_eq(pser2.argmax(), psser2.argmax()) | ||
| self.assert_eq(pser2.argmin(skipna=False), psser2.argmin(skipna=False)) | ||
| self.assert_eq(pser2.argmax(skipna=False), psser2.argmax(skipna=False)) | ||
|
|
||
| # Null Series | ||
| self.assert_eq(pd.Series([np.nan]).argmin(), ps.Series([np.nan]).argmin()) |
There was a problem hiding this comment.
both pd.Series([np.nan]).argmin() and ps.Series([np.nan]).argmin() return -1
HyukjinKwon
reviewed
Aug 1, 2022
python/pyspark/pandas/series.py
Outdated
| """ | ||
| Return int position of the smallest value in the Series. | ||
|
|
||
| If the minimum is achieved in multiple locations, | ||
| the first row position is returned. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| axis : {{None}} |
There was a problem hiding this comment.
Seems like a mistake? {{None}}
|
Merged to master. |
|
thank you @Yikun @HyukjinKwon for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1, Implement axis and skipna of Series.argmin
2, compute the argmin on single pass, like
argmaxWhy are the changes needed?
to add missing parameter
after this change, the underlying implements of argmax and argmin are almost the same
Does this PR introduce any user-facing change?
yes, new parameter
How was this patch tested?
added tests