Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-4966][YARN]The MemoryOverhead value is setted not correctly #3797

Closed
wants to merge 1 commit into from
Closed

[SPARK-4966][YARN]The MemoryOverhead value is setted not correctly #3797

wants to merge 1 commit into from

Conversation

XuTingjun
Copy link
Contributor

No description provided.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@JoshRosen
Copy link
Contributor

Can you provide some context / motivation for this change? If this fixes a bug, could you file a JIRA for it and link it to this PR?

@XuTingjun XuTingjun changed the title Update ClientArguments.scala [SPARK-4966][YARN]The MemoryOverhead value is setted not correctly Dec 25, 2014
@XuTingjun
Copy link
Contributor Author

@JoshRosen I am sorry to forget describe this patch. I have created a jira for it, can you take a look?

@JoshRosen
Copy link
Contributor

I can take a look at this later this week. It would probably be a good idea for someone more familiar with the YARN code to take a look, too, since they might also be able to suggest how/whether tests could have prevented the underlying bug.

@lianhuiwang
Copy link
Contributor

@XuTingjun yes, i agree with you. we should let parseArgs before using config amMemory and executorMemory. because parseArgs can change these value from args.

@tgravescs
Copy link
Contributor

Looks good. +1. Thanks @XuTingjun

@asfgit asfgit closed this in 14fa87b Dec 29, 2014
asfgit pushed a commit that referenced this pull request Dec 29, 2014
@XuTingjun @tgravescs
[SPARK-4966][YARN]The MemoryOverhead value is setted not correctly
2cd446a 
Author: meiyoula <1039320815@qq.com>

Closes #3797 from XuTingjun/MemoryOverhead and squashes the following commits:

5a780fc [meiyoula] Update ClientArguments.scala

(cherry picked from commit 14fa87b)
Signed-off-by: Thomas Graves <tgraves@apache.org>
@XuTingjun XuTingjun deleted the MemoryOverhead branch June 9, 2015 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XuTingjun @AmplabJenkins @JoshRosen @lianhuiwang @tgravescs