Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-40718][BUILD][CONNECT][FOLLOWUP] Explicitly add Netty related dependencies for the connect module #38185

Closed
wants to merge 2 commits into from

Conversation

LuciferYang
Copy link
Contributor

What changes were proposed in this pull request?

After #38179, there are 2 netty version in Spark:

  • 4.1.72 for connect module
  • 4.1.80 for other modules

So this pr explicitly add netty related dependencies for the connect module to ensure Spark use unified netty version.

Why are the changes needed?

Ensure Spark use unified netty version.

Does this PR introduce any user-facing change?

No

How was this patch tested?

  • Pass GitHub Actions
  • Manual test:

run mvn dependency:tree -pl connector/connect | grep netty

Before

[INFO] |  +- io.netty:netty-all:jar:4.1.80.Final:provided
[INFO] |  |  +- io.netty:netty-buffer:jar:4.1.80.Final:compile
[INFO] |  |  +- io.netty:netty-codec:jar:4.1.80.Final:compile
[INFO] |  |  +- io.netty:netty-common:jar:4.1.80.Final:compile
[INFO] |  |  +- io.netty:netty-handler:jar:4.1.80.Final:compile
[INFO] |  |  +- io.netty:netty-resolver:jar:4.1.80.Final:provided
[INFO] |  |  +- io.netty:netty-transport:jar:4.1.80.Final:compile
[INFO] |  |  +- io.netty:netty-transport-classes-epoll:jar:4.1.80.Final:provided
[INFO] |  |  \- io.netty:netty-transport-classes-kqueue:jar:4.1.80.Final:provided
[INFO] |  +- io.netty:netty-transport-native-epoll:jar:linux-x86_64:4.1.80.Final:provided
[INFO] |  +- io.netty:netty-transport-native-epoll:jar:linux-aarch_64:4.1.80.Final:provided
[INFO] |  +- io.netty:netty-transport-native-kqueue:jar:osx-aarch_64:4.1.80.Final:provided
[INFO] |  +- io.netty:netty-transport-native-kqueue:jar:osx-x86_64:4.1.80.Final:provided
[INFO] |  +- io.netty:netty-tcnative-classes:jar:2.0.54.Final:provided
[INFO] |  \- org.apache.arrow:arrow-memory-netty:jar:9.0.0:provided
[INFO] +- io.grpc:grpc-netty:jar:1.47.0:compile
[INFO] |  +- io.netty:netty-codec-http2:jar:4.1.72.Final:compile
[INFO] |  |  \- io.netty:netty-codec-http:jar:4.1.72.Final:compile
[INFO] |  +- io.netty:netty-handler-proxy:jar:4.1.72.Final:runtime
[INFO] |  |  \- io.netty:netty-codec-socks:jar:4.1.72.Final:runtime
[INFO] |  \- io.netty:netty-transport-native-unix-common:jar:4.1.72.Final:runtime

After

[INFO] |  +- io.netty:netty-all:jar:4.1.80.Final:provided
[INFO] |  |  +- io.netty:netty-resolver:jar:4.1.80.Final:provided
[INFO] |  |  +- io.netty:netty-transport-classes-epoll:jar:4.1.80.Final:provided
[INFO] |  |  \- io.netty:netty-transport-classes-kqueue:jar:4.1.80.Final:provided
[INFO] |  +- io.netty:netty-transport-native-epoll:jar:linux-x86_64:4.1.80.Final:provided
[INFO] |  +- io.netty:netty-transport-native-epoll:jar:linux-aarch_64:4.1.80.Final:provided
[INFO] |  +- io.netty:netty-transport-native-kqueue:jar:osx-aarch_64:4.1.80.Final:provided
[INFO] |  +- io.netty:netty-transport-native-kqueue:jar:osx-x86_64:4.1.80.Final:provided
[INFO] |  +- io.netty:netty-tcnative-classes:jar:2.0.54.Final:provided
[INFO] |  \- org.apache.arrow:arrow-memory-netty:jar:9.0.0:provided
[INFO] +- io.grpc:grpc-netty:jar:1.47.0:compile
[INFO] +- io.netty:netty-codec-http2:jar:4.1.80.Final:provided
[INFO] |  +- io.netty:netty-common:jar:4.1.80.Final:provided
[INFO] |  +- io.netty:netty-buffer:jar:4.1.80.Final:provided
[INFO] |  +- io.netty:netty-transport:jar:4.1.80.Final:provided
[INFO] |  +- io.netty:netty-codec:jar:4.1.80.Final:provided
[INFO] |  +- io.netty:netty-handler:jar:4.1.80.Final:provided
[INFO] |  \- io.netty:netty-codec-http:jar:4.1.80.Final:provided
[INFO] +- io.netty:netty-handler-proxy:jar:4.1.80.Final:provided
[INFO] |  \- io.netty:netty-codec-socks:jar:4.1.80.Final:provided
[INFO] +- io.netty:netty-transport-native-unix-common:jar:4.1.80.Final:provided

@LuciferYang LuciferYang changed the title [SPARK-40718][BUILD][FOLLOWUP] Explicitly add Netty related dependencies for the connect module [SPARK-40718][BUILD][CONNECT][FOLLOWUP] Explicitly add Netty related dependencies for the connect module Oct 10, 2022
@LuciferYang
Copy link
Contributor Author

Copy link
Contributor

@zhengruifeng zhengruifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -187,8 +187,12 @@ metrics-jvm/4.2.10//metrics-jvm-4.2.10.jar
minlog/1.3.0//minlog-1.3.0.jar
netty-all/4.1.80.Final//netty-all-4.1.80.Final.jar
netty-buffer/4.1.80.Final//netty-buffer-4.1.80.Final.jar
netty-codec-http/4.1.80.Final//netty-codec-http-4.1.80.Final.jar
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new 4 jars about 1232KB

@LuciferYang
Copy link
Contributor Author

GA passed

@HyukjinKwon
Copy link
Member

Merged to master.

@dongjoon-hyun
Copy link
Member

+1, very late LGTM. Thank you. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants