Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-40718][BUILD][CONNECT][FOLLOWUP] Explicitly add Netty related dependencies for the connect module #38185

Closed
wants to merge 2 commits into from
Closed

[SPARK-40718][BUILD][CONNECT][FOLLOWUP] Explicitly add Netty related dependencies for the connect module #38185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f6cb44
fix
LuciferYang Oct 10, 2022
0a5b58d
update deps file
LuciferYang Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 18 additions & 0 deletions connector/connect/pom.xml
View file
Open in desktop
Expand Up @@ -152,6 +152,24 @@
<artifactId>grpc-stub</artifactId>
<version>${io.grpc.version}</version>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-codec-http2</artifactId>
<version>${netty.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-handler-proxy</artifactId>
<version>${netty.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-transport-native-unix-common</artifactId>
<version>${netty.version}</version>
<scope>provided</scope>
</dependency>
<dependency> <!-- necessary for Java 9+ -->
<groupId>org.apache.tomcat</groupId>
<artifactId>annotations-api</artifactId>
Expand Down
4 changes: 4 additions & 0 deletions dev/deps/spark-deps-hadoop-2-hive-2.3
View file
Open in desktop
Expand Up @@ -203,8 +203,12 @@ metrics-jvm/4.2.10//metrics-jvm-4.2.10.jar
minlog/1.3.0//minlog-1.3.0.jar
netty-all/4.1.80.Final//netty-all-4.1.80.Final.jar
netty-buffer/4.1.80.Final//netty-buffer-4.1.80.Final.jar
netty-codec-http/4.1.80.Final//netty-codec-http-4.1.80.Final.jar
netty-codec-http2/4.1.80.Final//netty-codec-http2-4.1.80.Final.jar
netty-codec-socks/4.1.80.Final//netty-codec-socks-4.1.80.Final.jar
netty-codec/4.1.80.Final//netty-codec-4.1.80.Final.jar
netty-common/4.1.80.Final//netty-common-4.1.80.Final.jar
netty-handler-proxy/4.1.80.Final//netty-handler-proxy-4.1.80.Final.jar
netty-handler/4.1.80.Final//netty-handler-4.1.80.Final.jar
netty-resolver/4.1.80.Final//netty-resolver-4.1.80.Final.jar
netty-tcnative-classes/2.0.54.Final//netty-tcnative-classes-2.0.54.Final.jar
Expand Down
4 changes: 4 additions & 0 deletions dev/deps/spark-deps-hadoop-3-hive-2.3
View file
Open in desktop
Expand Up @@ -187,8 +187,12 @@ metrics-jvm/4.2.10//metrics-jvm-4.2.10.jar
minlog/1.3.0//minlog-1.3.0.jar
netty-all/4.1.80.Final//netty-all-4.1.80.Final.jar
netty-buffer/4.1.80.Final//netty-buffer-4.1.80.Final.jar
netty-codec-http/4.1.80.Final//netty-codec-http-4.1.80.Final.jar
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new 4 jars about 1232KB

netty-codec-http2/4.1.80.Final//netty-codec-http2-4.1.80.Final.jar
netty-codec-socks/4.1.80.Final//netty-codec-socks-4.1.80.Final.jar
netty-codec/4.1.80.Final//netty-codec-4.1.80.Final.jar
netty-common/4.1.80.Final//netty-common-4.1.80.Final.jar
netty-handler-proxy/4.1.80.Final//netty-handler-proxy-4.1.80.Final.jar
netty-handler/4.1.80.Final//netty-handler-4.1.80.Final.jar
netty-resolver/4.1.80.Final//netty-resolver-4.1.80.Final.jar
netty-tcnative-classes/2.0.54.Final//netty-tcnative-classes-2.0.54.Final.jar
Expand Down
16 changes: 0 additions & 16 deletions pom.xml
View file
Open in desktop
Expand Up @@ -843,14 +843,6 @@
<groupId>io.netty</groupId>
<artifactId>netty-codec-haproxy</artifactId>
</exclusion>
<exclusion>
<groupId>io.netty</groupId>
<artifactId>netty-codec-http</artifactId>
</exclusion>
<exclusion>
<groupId>io.netty</groupId>
<artifactId>netty-codec-http2</artifactId>
</exclusion>
<exclusion>
<groupId>io.netty</groupId>
<artifactId>netty-codec-memcache</artifactId>
Expand All @@ -867,10 +859,6 @@
<groupId>io.netty</groupId>
<artifactId>netty-codec-smtp</artifactId>
</exclusion>
<exclusion>
<groupId>io.netty</groupId>
<artifactId>netty-codec-socks</artifactId>
</exclusion>
<exclusion>
<groupId>io.netty</groupId>
<artifactId>netty-codec-stomp</artifactId>
Expand All @@ -879,10 +867,6 @@
<groupId>io.netty</groupId>
<artifactId>netty-codec-xml</artifactId>
</exclusion>
<exclusion>
<groupId>io.netty</groupId>
<artifactId>netty-handler-proxy</artifactId>
</exclusion>
<exclusion>
<groupId>io.netty</groupId>
<artifactId>netty-resolver-dns</artifactId>
Expand Down