[SPARK-41574][SQL] Update _LEGACY_ERROR_TEMP_2009 as INTERNAL_ERROR.
#39389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
requested changes
Jan 5, 2023
| messageParameters = Map.empty) | ||
| def dataTypeOperationUnsupportedError(): Throwable = { | ||
| SparkException.internalError( | ||
| s"""Operation dataType is not supported""") |
There was a problem hiding this comment.
Suggested change
| s"""Operation dataType is not supported""") | |
| "The operation `dataType` is not supported.") |
There was a problem hiding this comment.
Oh... didn't recognize that it's overwritten. 🙏
Just applied the change.
…xecutionErrors.scala Co-authored-by: Maxim Gekk <max.gekk@gmail.com>
MaxGekk
requested changes
Jan 7, 2023
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
Outdated
Show resolved
Hide resolved
itholic
changed the title
_LEGACY_ERROR_TEMP_2009 as INTERNAL_ERROR.
cloud-fan
approved these changes
Jan 18, 2023
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to update
_LEGACY_ERROR_TEMP_2136asINTERNAL_ERROR.Why are the changes needed?
We should turn error class into INTERNAL_ERROR when it's not triggered by user space.
Does this PR introduce any user-facing change?
No
How was this patch tested?
./build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*