Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-41574][SQL] Update _LEGACY_ERROR_TEMP_2009 as INTERNAL_ERROR. #39389

Closed
wants to merge 12 commits into from
Closed

[SPARK-41574][SQL] Update _LEGACY_ERROR_TEMP_2009 as INTERNAL_ERROR. #39389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
62a7406
[SPARK-41574][SQL] Assign name to _LEGACY_ERROR_TEMP_2009
itholic Jan 4, 2023
6afb85d
fix
itholic Jan 4, 2023
99b0c79
Merge branch 'master' of https://github.com/apache/spark into SPARK-4…
itholic Jan 5, 2023
d6ef406
Update sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryE…
itholic Jan 5, 2023
4c4c4c8
Move into QueryCompilationErrors
itholic Jan 9, 2023
72ac66d
sync commit
itholic Jan 9, 2023
c870063
import
itholic Jan 9, 2023
f736863
Merge branch 'master' of https://github.com/apache/spark into SPARK-4…
itholic Jan 9, 2023
14f539b
Merge branch 'master' of https://github.com/apache/spark into SPARK-4…
itholic Jan 9, 2023
4700c7c
Merge branch 'master' of https://github.com/apache/spark into SPARK-4…
itholic Jan 10, 2023
5a56aa6
Merge branch 'master' of https://github.com/apache/spark into SPARK-4…
itholic Jan 10, 2023
513f850
apply the suggestion
itholic Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions core/src/main/resources/error/error-classes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3518,11 +3518,6 @@
"Find an invalid url string <url>. If necessary set <ansiConfig> to false to bypass this error."
]
},
"_LEGACY_ERROR_TEMP_2009" : {
"message" : [
"dataType"
]
},
"_LEGACY_ERROR_TEMP_2010" : {
"message" : [
"Window Functions do not support merging."
Expand Down
6 changes: 3 additions & 3 deletions ...catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import org.apache.spark.sql.catalyst.expressions.Cast.{toSQLExpr, toSQLType}
import org.apache.spark.sql.catalyst.expressions.aggregate.{AggregateFunction, DeclarativeAggregate, NoOp}
import org.apache.spark.sql.catalyst.trees.{BinaryLike, LeafLike, TernaryLike, UnaryLike}
import org.apache.spark.sql.catalyst.trees.TreePattern.{TreePattern, UNRESOLVED_WINDOW_EXPRESSION, WINDOW_EXPRESSION}
import org.apache.spark.sql.errors.{QueryErrorsBase, QueryExecutionErrors}
import org.apache.spark.sql.errors.{QueryCompilationErrors, QueryErrorsBase, QueryExecutionErrors}
import org.apache.spark.sql.types._

/**
Expand Down Expand Up @@ -62,7 +62,7 @@ case class WindowSpecDefinition(
checkInputDataTypes().isSuccess

override def nullable: Boolean = true
override def dataType: DataType = throw QueryExecutionErrors.dataTypeOperationUnsupportedError
override def dataType: DataType = throw QueryCompilationErrors.dataTypeOperationUnsupportedError

override def checkInputDataTypes(): TypeCheckResult = {
frameSpecification match {
Expand Down Expand Up @@ -182,7 +182,7 @@ case object CurrentRow extends SpecialFrameBoundary {
* Represents a window frame.
*/
sealed trait WindowFrame extends Expression with Unevaluable {
override def dataType: DataType = throw QueryExecutionErrors.dataTypeOperationUnsupportedError
override def dataType: DataType = throw QueryCompilationErrors.dataTypeOperationUnsupportedError
override def nullable: Boolean = false
}

Expand Down
5 changes: 5 additions & 0 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3401,4 +3401,9 @@ private[sql] object QueryCompilationErrors extends QueryErrorsBase {
)
)
}

def dataTypeOperationUnsupportedError(): Throwable = {
SparkException.internalError(
"The operation `dataType` is not supported.")
}
}
6 changes: 0 additions & 6 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,12 +378,6 @@ private[sql] object QueryExecutionErrors extends QueryErrorsBase {
)
}

def dataTypeOperationUnsupportedError(): SparkUnsupportedOperationException = {
new SparkUnsupportedOperationException(
errorClass = "_LEGACY_ERROR_TEMP_2009",
messageParameters = Map.empty)
}

def mergeUnsupportedByWindowFunctionError(): SparkUnsupportedOperationException = {
new SparkUnsupportedOperationException(
errorClass = "_LEGACY_ERROR_TEMP_2010",
Expand Down